Commit 4c8702b3 authored by Guenter Roeck's avatar Guenter Roeck

hwmon: (ftsteutates) Fix potential memory access error

Using set_bit() to set a bit in an integer is not a good idea, since
the function expects an unsigned long as argument, which can be 64 bit
wide. Coverity reports this problem as

>>>     CID 1364488:  Memory - illegal accesses  (INCOMPATIBLE_CAST)
>>>     Pointer "&ret" points to an object whose effective type is "int"
>>>	(32 bits, signed) but is dereferenced as a wider "unsigned
+long" (64 bits, unsigned).  This may lead to memory corruption.
245                     set_bit(1, (unsigned long *)&ret);

Just use BIT instead.

Cc: Thilo Cestonaro <thilo@cestona.ro>
Fixes: 08426eda ("hwmon: Add driver for FTS BMC chip "Teutates"")
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 1aa4f028
...@@ -242,7 +242,7 @@ static int fts_wd_set_resolution(struct fts_data *data, ...@@ -242,7 +242,7 @@ static int fts_wd_set_resolution(struct fts_data *data,
} }
if (resolution == seconds) if (resolution == seconds)
set_bit(1, (unsigned long *)&ret); ret |= BIT(1);
else else
ret &= ~BIT(1); ret &= ~BIT(1);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment