Commit 4ced8c64 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman

staging: comedi: usbduxsigma: tidy up usbdux_pwm_write()

Rename the function so it has namespace associated with the driver.

Tidy up the comments.
Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 92f687ba
...@@ -1366,24 +1366,25 @@ static int usbdux_pwm_pattern(struct comedi_device *dev, ...@@ -1366,24 +1366,25 @@ static int usbdux_pwm_pattern(struct comedi_device *dev,
return 1; return 1;
} }
static int usbdux_pwm_write(struct comedi_device *dev, static int usbduxsigma_pwm_write(struct comedi_device *dev,
struct comedi_subdevice *s, struct comedi_subdevice *s,
struct comedi_insn *insn, unsigned int *data) struct comedi_insn *insn,
unsigned int *data)
{ {
if ((insn->n) != 1) { unsigned int chan = CR_CHAN(insn->chanspec);
/*
* doesn't make sense to have more than one value here because /*
* it would just overwrite the PWM buffer a couple of times * It doesn't make sense to support more than one value here
*/ * because it would just overwrite the PWM buffer.
*/
if (insn->n != 1)
return -EINVAL; return -EINVAL;
}
/* /*
* the sign is set via a special INSN only, this gives us 8 bits for * The sign is set via a special INSN only, this gives us 8 bits
* normal operation * for normal operation, sign is 0 by default.
* relay sign 0 by default
*/ */
return usbdux_pwm_pattern(dev, s, CR_CHAN(insn->chanspec), data[0], 0); return usbdux_pwm_pattern(dev, s, chan, data[0], 0);
} }
static int usbduxsigma_pwm_config(struct comedi_device *dev, static int usbduxsigma_pwm_config(struct comedi_device *dev,
...@@ -1543,7 +1544,7 @@ static int usbduxsigma_attach_common(struct comedi_device *dev) ...@@ -1543,7 +1544,7 @@ static int usbduxsigma_attach_common(struct comedi_device *dev)
s->subdev_flags = SDF_WRITABLE | SDF_PWM_HBRIDGE; s->subdev_flags = SDF_WRITABLE | SDF_PWM_HBRIDGE;
s->n_chan = 8; s->n_chan = 8;
s->maxdata = devpriv->sizePwmBuf; s->maxdata = devpriv->sizePwmBuf;
s->insn_write = usbdux_pwm_write; s->insn_write = usbduxsigma_pwm_write;
s->insn_config = usbduxsigma_pwm_config; s->insn_config = usbduxsigma_pwm_config;
usbdux_pwm_period(dev, s, PWM_DEFAULT_PERIOD); usbdux_pwm_period(dev, s, PWM_DEFAULT_PERIOD);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment