Commit 4cf9cf89 authored by Wei Yongjun's avatar Wei Yongjun Committed by Tony Lindgren

ARM: OMAP: fix return value check in omap_device_build_from_dt()

In case of error, the function omap_device_alloc() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().
Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: default avatarKevin Hilman <khilman@linaro.org>
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
parent 2cfeed31
...@@ -158,7 +158,7 @@ static int omap_device_build_from_dt(struct platform_device *pdev) ...@@ -158,7 +158,7 @@ static int omap_device_build_from_dt(struct platform_device *pdev)
} }
od = omap_device_alloc(pdev, hwmods, oh_cnt); od = omap_device_alloc(pdev, hwmods, oh_cnt);
if (!od) { if (IS_ERR(od)) {
dev_err(&pdev->dev, "Cannot allocate omap_device for :%s\n", dev_err(&pdev->dev, "Cannot allocate omap_device for :%s\n",
oh_name); oh_name);
ret = PTR_ERR(od); ret = PTR_ERR(od);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment