Commit 4d10e0f2 authored by Wei Yongjun's avatar Wei Yongjun Committed by Linus Torvalds

drivers/w1/slaves/w1_ds2760.c: fix the error handling in w1_ds2760_add_slave()

Use platform_device_put() instead of platform_device_unregister() if
platform_device_add() fail, and platform_device_del() should be used in
the error handling case after platform_device_add() success.
Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Cc: Evgeniy Polyakov <zbr@ioremap.net>
Cc: Greg KH <greg@kroah.com>
Cc: Neil Brown <neilb@suse.de>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent c28d6f2d
...@@ -148,8 +148,9 @@ static int w1_ds2760_add_slave(struct w1_slave *sl) ...@@ -148,8 +148,9 @@ static int w1_ds2760_add_slave(struct w1_slave *sl)
goto success; goto success;
bin_attr_failed: bin_attr_failed:
platform_device_del(pdev);
pdev_add_failed: pdev_add_failed:
platform_device_unregister(pdev); platform_device_put(pdev);
pdev_alloc_failed: pdev_alloc_failed:
ida_simple_remove(&bat_ida, id); ida_simple_remove(&bat_ida, id);
noid: noid:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment