Commit 4d4e2c00 authored by Ian Abbott's avatar Ian Abbott Committed by Tomi Valkeinen

video: da8xx-fb: preserve display width when changing HSYNC

When looking at this driver for a client, I noticed the code that
configures the HSYNC pulse clobbers the display width in the same
register.  It only preserves the MS part of the width in bit 3 and zeros
the LS part of the width in bits 9 to 4.  This doesn't matter during
initialization as the width is configured afterwards, but subsequent use
of the FBIPUT_HSYNC ioctl would clobber the width.

Preserve bits 9 to 0 of LCD_RASTER_TIMING_0_REG when configuring the
horizontal sync.
Signed-off-by: default avatarIan Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent 62795a0d
...@@ -419,7 +419,7 @@ static void lcd_cfg_horizontal_sync(int back_porch, int pulse_width, ...@@ -419,7 +419,7 @@ static void lcd_cfg_horizontal_sync(int back_porch, int pulse_width,
{ {
u32 reg; u32 reg;
reg = lcdc_read(LCD_RASTER_TIMING_0_REG) & 0xf; reg = lcdc_read(LCD_RASTER_TIMING_0_REG) & 0x3ff;
reg |= (((back_porch-1) & 0xff) << 24) reg |= (((back_porch-1) & 0xff) << 24)
| (((front_porch-1) & 0xff) << 16) | (((front_porch-1) & 0xff) << 16)
| (((pulse_width-1) & 0x3f) << 10); | (((pulse_width-1) & 0x3f) << 10);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment