Commit 4d9b2ebd authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Mauro Carvalho Chehab

[media] uvcvideo: Fix crash when linking entities

The uvc_mc_register_entity() function wrongfully selects the
media_entity associated with a UVC entity when creating links. This
results in access to uninitialized media_entity structures and can hit a
BUG_ON statement in media_entity_create_link(). Fix it.
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 236c5441
...@@ -49,7 +49,7 @@ static int uvc_mc_register_entity(struct uvc_video_chain *chain, ...@@ -49,7 +49,7 @@ static int uvc_mc_register_entity(struct uvc_video_chain *chain,
if (remote == NULL) if (remote == NULL)
return -EINVAL; return -EINVAL;
source = (UVC_ENTITY_TYPE(remote) != UVC_TT_STREAMING) source = (UVC_ENTITY_TYPE(remote) == UVC_TT_STREAMING)
? (remote->vdev ? &remote->vdev->entity : NULL) ? (remote->vdev ? &remote->vdev->entity : NULL)
: &remote->subdev.entity; : &remote->subdev.entity;
if (source == NULL) if (source == NULL)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment