Commit 4e3a024b authored by Joe Damato's avatar Joe Damato Committed by Jakub Kicinski

netdev-genl: Set extack and fix error on napi-get

In commit 27f91aaf ("netdev-genl: Add netlink framework functions
for napi"), when an invalid NAPI ID is specified the return value
-EINVAL is used and no extack is set.

Change the return value to -ENOENT and set the extack.

Before this commit:

$ ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \
                          --do napi-get --json='{"id": 451}'
Netlink error: Invalid argument
nl_len = 36 (20) nl_flags = 0x100 nl_type = 2
	error: -22

After this commit:

$ ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \
                         --do napi-get --json='{"id": 451}'
Netlink error: No such file or directory
nl_len = 44 (28) nl_flags = 0x300 nl_type = 2
	error: -2
	extack: {'bad-attr': '.id'}
Suggested-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarJoe Damato <jdamato@fastly.com>
Link: https://patch.msgid.link/20240831121707.17562-1-jdamato@fastly.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 55ddb6c5
...@@ -216,10 +216,12 @@ int netdev_nl_napi_get_doit(struct sk_buff *skb, struct genl_info *info) ...@@ -216,10 +216,12 @@ int netdev_nl_napi_get_doit(struct sk_buff *skb, struct genl_info *info)
rtnl_lock(); rtnl_lock();
napi = napi_by_id(napi_id); napi = napi_by_id(napi_id);
if (napi) if (napi) {
err = netdev_nl_napi_fill_one(rsp, napi, info); err = netdev_nl_napi_fill_one(rsp, napi, info);
else } else {
err = -EINVAL; NL_SET_BAD_ATTR(info->extack, info->attrs[NETDEV_A_NAPI_ID]);
err = -ENOENT;
}
rtnl_unlock(); rtnl_unlock();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment