Commit 4eaa3a6c authored by Tapasweni Pathak's avatar Tapasweni Pathak Committed by Mauro Carvalho Chehab

[media] drivers: media: platform: vivid: Fix possible null derefrence

Check for dev_fmt being null before derefrencing it, to assign it
to planes.

Found using Coccinelle.
Signed-off-by: default avatarTapasweni Pathak <tapaswenipathak@gmail.com>
Acked-by: default avatarJulia Lawall <julia.lawall@lip6.fr>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 64bf8049
...@@ -114,7 +114,7 @@ static int vid_out_buf_prepare(struct vb2_buffer *vb) ...@@ -114,7 +114,7 @@ static int vid_out_buf_prepare(struct vb2_buffer *vb)
{ {
struct vivid_dev *dev = vb2_get_drv_priv(vb->vb2_queue); struct vivid_dev *dev = vb2_get_drv_priv(vb->vb2_queue);
unsigned long size; unsigned long size;
unsigned planes = dev->fmt_out->planes; unsigned planes;
unsigned p; unsigned p;
dprintk(dev, 1, "%s\n", __func__); dprintk(dev, 1, "%s\n", __func__);
...@@ -122,6 +122,8 @@ static int vid_out_buf_prepare(struct vb2_buffer *vb) ...@@ -122,6 +122,8 @@ static int vid_out_buf_prepare(struct vb2_buffer *vb)
if (WARN_ON(NULL == dev->fmt_out)) if (WARN_ON(NULL == dev->fmt_out))
return -EINVAL; return -EINVAL;
planes = dev->fmt_out->planes;
if (dev->buf_prepare_error) { if (dev->buf_prepare_error) {
/* /*
* Error injection: test what happens if buf_prepare() returns * Error injection: test what happens if buf_prepare() returns
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment