Skip to content

L
linux
Commit 4ee59d54 authored by Hannes Eder's avatar Hannes Eder Committed by David S. Miller
Browse files
Options

isdn: eicon: fix sparse warning: make global functions static 

Fix this sparse warnings by making the functions static:

  drivers/isdn/hardware/eicon/di.c:356:6: warning: symbol 'isdn_rc' was not declared. Should it be static?
  drivers/isdn/hardware/eicon/di.c:558:6: warning: symbol 'isdn_ind' was not declared. Should it be static?
  drivers/isdn/hardware/eicon/message.c:595:6: warning: symbol 'api_parse' was not declared. Should it be static?
  drivers/isdn/hardware/eicon/message.c:634:6: warning: symbol 'api_save_msg' was not declared. Should it be static?
  drivers/isdn/hardware/eicon/message.c:666:6: warning: symbol 'api_load_msg' was not declared. Should it be static?
  drivers/isdn/hardware/eicon/message.c:3417:6: warning: symbol 'manufacturer_req' was not declared. Should it be static?
  drivers/isdn/hardware/eicon/message.c:3745:6: warning: symbol 'manufacturer_res' was not declared. Should it be static?
  drivers/isdn/hardware/eicon/message.c:4077:6: warning: symbol 'control_rc' was not declared. Should it be static?
  drivers/isdn/hardware/eicon/message.c:4743:6: warning: symbol 'data_rc' was not declared. Should it be static?
  drivers/isdn/hardware/eicon/message.c:4779:6: warning: symbol 'data_ack' was not declared. Should it be static?
  drivers/isdn/hardware/eicon/message.c:4805:6: warning: symbol 'sig_ind' was not declared. Should it be static?
  drivers/isdn/hardware/eicon/message.c:6173:6: warning: symbol 'SendInfo' was not declared. Should it be static?
  drivers/isdn/hardware/eicon/message.c:6349:6: warning: symbol 'SendMultiIE' was not declared. Should it be static?
  drivers/isdn/hardware/eicon/message.c:6468:6: warning: symbol 'nl_ind' was not declared. Should it be static?
  drivers/isdn/hardware/eicon/message.c:7250:6: warning: symbol 'get_plci' was not declared. Should it be static?
  drivers/isdn/hardware/eicon/message.c:7409:6: warning: symbol 'add_d' was not declared. Should it be static?
  drivers/isdn/hardware/eicon/message.c:7427:6: warning: symbol 'add_ai' was not declared. Should it be static?
  drivers/isdn/hardware/eicon/message.c:7448:6: warning: symbol 'add_b1' was not declared. Should it be static?
  drivers/isdn/hardware/eicon/message.c:7912:6: warning: symbol 'add_b23' was not declared. Should it be static?
  drivers/isdn/hardware/eicon/message.c:8709:6: warning: symbol 'nl_req_ncci' was not declared. Should it be static?
  drivers/isdn/hardware/eicon/message.c:8731:6: warning: symbol 'send_req' was not declared. Should it be static?
  drivers/isdn/hardware/eicon/message.c:8866:6: warning: symbol 'listen_check' was not declared. Should it be static?
  drivers/isdn/hardware/eicon/message.c:8909:6: warning: symbol 'IndParse' was not declared. Should it be static?
  drivers/isdn/hardware/eicon/message.c:8994:6: warning: symbol 'ie_compare' was not declared. Should it be static?
  drivers/isdn/hardware/eicon/message.c:9003:6: warning: symbol 'find_cip' was not declared. Should it be static?
  drivers/isdn/hardware/eicon/message.c:9071:6: warning: symbol 'SetVoiceChannel' was not declared. Should it be static?
  drivers/isdn/hardware/eicon/message.c:9089:6: warning: symbol 'VoiceChannelOff' was not declared. Should it be static?
  drivers/isdn/hardware/eicon/message.c:9102:6: warning: symbol 'AdvCodecSupport' was not declared. Should it be static?
  drivers/isdn/hardware/eicon/message.c:9198:6: warning: symbol 'CodecIdCheck' was not declared. Should it be static?
Signed-off-by: default avatarHannes Eder <hannes@hanneseder.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b1879204
Show whitespace changes
Inline Side-by-side
Showing with 47 additions and 41 deletions
drivers/isdn/hardware/eicon/di.c
View file @ 4ee59d54
...@@ -353,7 +353,7 @@ void scom_clear_int(ADAPTER * a) ...@@ -353,7 +353,7 @@ void scom_clear_int(ADAPTER * a)
/*------------------------------------------------------------------*/ /*------------------------------------------------------------------*/
/* return code handler */ /* return code handler */
/*------------------------------------------------------------------*/ /*------------------------------------------------------------------*/
byte isdn_rc(ADAPTER * a, static byte isdn_rc(ADAPTER *a,
byte Rc, byte Rc,
byte Id, byte Id,
byte Ch, byte Ch,
...@@ -555,11 +555,11 @@ byte isdn_rc(ADAPTER * a, ...@@ -555,11 +555,11 @@ byte isdn_rc(ADAPTER * a,
/*------------------------------------------------------------------*/ /*------------------------------------------------------------------*/
/* indication handler */ /* indication handler */
/*------------------------------------------------------------------*/ /*------------------------------------------------------------------*/
byte isdn_ind(ADAPTER * a, static byte isdn_ind(ADAPTER *a,
byte Ind, byte Ind,
byte Id, byte Id,
byte Ch, byte Ch,
PBUFFER * RBuffer, PBUFFER *RBuffer,
byte MInd, byte MInd,
word MLength) word MLength)
{ {
......
drivers/isdn/hardware/eicon/message.c
View file @ 4ee59d54
...@@ -592,7 +592,7 @@ word api_put(APPL * appl, CAPI_MSG * msg) ...@@ -592,7 +592,7 @@ word api_put(APPL * appl, CAPI_MSG * msg)
/* api_parse function, check the format of api messages */ /* api_parse function, check the format of api messages */
/*------------------------------------------------------------------*/ /*------------------------------------------------------------------*/
word api_parse(byte * msg, word length, byte * format, API_PARSE * parms) static word api_parse(byte *msg, word length, byte *format, API_PARSE *parms)
{ {
word i; word i;
word p; word p;
...@@ -631,7 +631,7 @@ word api_parse(byte * msg, word length, byte * format, API_PARSE * parms) ...@@ -631,7 +631,7 @@ word api_parse(byte * msg, word length, byte * format, API_PARSE * parms)
return false; return false;
} }
void api_save_msg(API_PARSE *in, byte *format, API_SAVE *out) static void api_save_msg(API_PARSE *in, byte *format, API_SAVE *out)
{ {
word i, j, n = 0; word i, j, n = 0;
byte *p; byte *p;
...@@ -663,7 +663,7 @@ void api_save_msg(API_PARSE *in, byte *format, API_SAVE *out) ...@@ -663,7 +663,7 @@ void api_save_msg(API_PARSE *in, byte *format, API_SAVE *out)
out->parms[i].length = 0; out->parms[i].length = 0;
} }
void api_load_msg(API_SAVE *in, API_PARSE *out) static void api_load_msg(API_SAVE *in, API_PARSE *out)
{ {
word i; word i;
...@@ -3414,7 +3414,8 @@ byte select_b_req(dword Id, word Number, DIVA_CAPI_ADAPTER * a, PLCI * plci, ...@@ -3414,7 +3414,8 @@ byte select_b_req(dword Id, word Number, DIVA_CAPI_ADAPTER * a, PLCI * plci,
return false; return false;
} }
byte manufacturer_req(dword Id, word Number, DIVA_CAPI_ADAPTER * a, PLCI * plci, APPL * appl, API_PARSE * parms) static byte manufacturer_req(dword Id, word Number, DIVA_CAPI_ADAPTER *a,
PLCI *plci, APPL *appl, API_PARSE *parms)
{ {
word command; word command;
word i; word i;
...@@ -3742,7 +3743,8 @@ byte manufacturer_req(dword Id, word Number, DIVA_CAPI_ADAPTER * a, PLCI * p ...@@ -3742,7 +3743,8 @@ byte manufacturer_req(dword Id, word Number, DIVA_CAPI_ADAPTER * a, PLCI * p
} }
byte manufacturer_res(dword Id, word Number, DIVA_CAPI_ADAPTER * a, PLCI * plci, APPL * appl, API_PARSE * msg) static byte manufacturer_res(dword Id, word Number, DIVA_CAPI_ADAPTER *a,
PLCI *plci, APPL *appl, API_PARSE *msg)
{ {
word indication; word indication;
...@@ -4074,7 +4076,8 @@ void callback(ENTITY * e) ...@@ -4074,7 +4076,8 @@ void callback(ENTITY * e)
} }
void control_rc(PLCI * plci, byte req, byte rc, byte ch, byte global_req, byte nl_rc) static void control_rc(PLCI *plci, byte req, byte rc, byte ch, byte global_req,
byte nl_rc)
{ {
dword Id; dword Id;
dword rId; dword rId;
...@@ -4740,7 +4743,7 @@ void control_rc(PLCI * plci, byte req, byte rc, byte ch, byte global_req, byte ...@@ -4740,7 +4743,7 @@ void control_rc(PLCI * plci, byte req, byte rc, byte ch, byte global_req, byte
} }
} }
void data_rc(PLCI * plci, byte ch) static void data_rc(PLCI *plci, byte ch)
{ {
dword Id; dword Id;
DIVA_CAPI_ADAPTER * a; DIVA_CAPI_ADAPTER * a;
...@@ -4776,7 +4779,7 @@ void data_rc(PLCI * plci, byte ch) ...@@ -4776,7 +4779,7 @@ void data_rc(PLCI * plci, byte ch)
} }
} }
void data_ack(PLCI * plci, byte ch) static void data_ack(PLCI *plci, byte ch)
{ {
dword Id; dword Id;
DIVA_CAPI_ADAPTER * a; DIVA_CAPI_ADAPTER * a;
...@@ -4802,7 +4805,7 @@ void data_ack(PLCI * plci, byte ch) ...@@ -4802,7 +4805,7 @@ void data_ack(PLCI * plci, byte ch)
} }
} }
void sig_ind(PLCI * plci) static void sig_ind(PLCI *plci)
{ {
dword x_Id; dword x_Id;
dword Id; dword Id;
...@@ -6170,7 +6173,7 @@ static void SendSetupInfo(APPL * appl, PLCI * plci, dword Id, byte * * par ...@@ -6170,7 +6173,7 @@ static void SendSetupInfo(APPL * appl, PLCI * plci, dword Id, byte * * par
} }
void SendInfo(PLCI * plci, dword Id, byte * * parms, byte iesent) static void SendInfo(PLCI *plci, dword Id, byte **parms, byte iesent)
{ {
word i; word i;
word j; word j;
...@@ -6346,7 +6349,8 @@ void SendInfo(PLCI * plci, dword Id, byte * * parms, byte iesent) ...@@ -6346,7 +6349,8 @@ void SendInfo(PLCI * plci, dword Id, byte * * parms, byte iesent)
} }
byte SendMultiIE(PLCI * plci, dword Id, byte * * parms, byte ie_type, dword info_mask, byte setupParse) static byte SendMultiIE(PLCI *plci, dword Id, byte **parms, byte ie_type,
dword info_mask, byte setupParse)
{ {
word i; word i;
word j; word j;
...@@ -6465,7 +6469,7 @@ static void SendSSExtInd(APPL * appl, PLCI * plci, dword Id, byte * * parm ...@@ -6465,7 +6469,7 @@ static void SendSSExtInd(APPL * appl, PLCI * plci, dword Id, byte * * parm
} }
}; };
void nl_ind(PLCI * plci) static void nl_ind(PLCI *plci)
{ {
byte ch; byte ch;
word ncci; word ncci;
...@@ -7247,7 +7251,7 @@ void nl_ind(PLCI * plci) ...@@ -7247,7 +7251,7 @@ void nl_ind(PLCI * plci)
/* find a free PLCI */ /* find a free PLCI */
/*------------------------------------------------------------------*/ /*------------------------------------------------------------------*/
word get_plci(DIVA_CAPI_ADAPTER * a) static word get_plci(DIVA_CAPI_ADAPTER *a)
{ {
word i,j; word i,j;
PLCI * plci; PLCI * plci;
...@@ -7406,7 +7410,7 @@ static void add_ie(PLCI * plci, byte code, byte * p, word p_length) ...@@ -7406,7 +7410,7 @@ static void add_ie(PLCI * plci, byte code, byte * p, word p_length)
/* put a unstructured data into the buffer */ /* put a unstructured data into the buffer */
/*------------------------------------------------------------------*/ /*------------------------------------------------------------------*/
void add_d(PLCI * plci, word length, byte * p) static void add_d(PLCI *plci, word length, byte *p)
{ {
word i; word i;
...@@ -7424,7 +7428,7 @@ void add_d(PLCI * plci, word length, byte * p) ...@@ -7424,7 +7428,7 @@ void add_d(PLCI * plci, word length, byte * p)
/* parameter buffer */ /* parameter buffer */
/*------------------------------------------------------------------*/ /*------------------------------------------------------------------*/
void add_ai(PLCI * plci, API_PARSE * ai) static void add_ai(PLCI *plci, API_PARSE *ai)
{ {
word i; word i;
API_PARSE ai_parms[5]; API_PARSE ai_parms[5];
...@@ -7445,7 +7449,8 @@ void add_ai(PLCI * plci, API_PARSE * ai) ...@@ -7445,7 +7449,8 @@ void add_ai(PLCI * plci, API_PARSE * ai)
/* put parameter for b1 protocol in the parameter buffer */ /* put parameter for b1 protocol in the parameter buffer */
/*------------------------------------------------------------------*/ /*------------------------------------------------------------------*/
word add_b1(PLCI * plci, API_PARSE * bp, word b_channel_info, word b1_facilities) static word add_b1(PLCI *plci, API_PARSE *bp, word b_channel_info,
word b1_facilities)
{ {
API_PARSE bp_parms[8]; API_PARSE bp_parms[8];
API_PARSE mdm_cfg[9]; API_PARSE mdm_cfg[9];
...@@ -7909,7 +7914,7 @@ word add_b1(PLCI * plci, API_PARSE * bp, word b_channel_info, word b1_faciliti ...@@ -7909,7 +7914,7 @@ word add_b1(PLCI * plci, API_PARSE * bp, word b_channel_info, word b1_faciliti
/* put parameter for b2 and B3 protocol in the parameter buffer */ /* put parameter for b2 and B3 protocol in the parameter buffer */
/*------------------------------------------------------------------*/ /*------------------------------------------------------------------*/
word add_b23(PLCI * plci, API_PARSE * bp) static word add_b23(PLCI *plci, API_PARSE *bp)
{ {
word i, fax_control_bits; word i, fax_control_bits;
byte pos, len; byte pos, len;
...@@ -8706,7 +8711,7 @@ void sig_req(PLCI * plci, byte req, byte Id) ...@@ -8706,7 +8711,7 @@ void sig_req(PLCI * plci, byte req, byte Id)
/* send a request for the network layer entity */ /* send a request for the network layer entity */
/*------------------------------------------------------------------*/ /*------------------------------------------------------------------*/
void nl_req_ncci(PLCI * plci, byte req, byte ncci) static void nl_req_ncci(PLCI *plci, byte req, byte ncci)
{ {
if(!plci) return; if(!plci) return;
if(plci->adapter->adapter_disabled) return; if(plci->adapter->adapter_disabled) return;
...@@ -8728,7 +8733,7 @@ void nl_req_ncci(PLCI * plci, byte req, byte ncci) ...@@ -8728,7 +8733,7 @@ void nl_req_ncci(PLCI * plci, byte req, byte ncci)
plci->req_in_start = plci->req_in; plci->req_in_start = plci->req_in;
} }
void send_req(PLCI * plci) static void send_req(PLCI *plci)
{ {
ENTITY * e; ENTITY * e;
word l; word l;
...@@ -8863,7 +8868,7 @@ void send_data(PLCI * plci) ...@@ -8863,7 +8868,7 @@ void send_data(PLCI * plci)
} }
} }
void listen_check(DIVA_CAPI_ADAPTER * a) static void listen_check(DIVA_CAPI_ADAPTER *a)
{ {
word i,j; word i,j;
PLCI * plci; PLCI * plci;
...@@ -8906,7 +8911,7 @@ void listen_check(DIVA_CAPI_ADAPTER * a) ...@@ -8906,7 +8911,7 @@ void listen_check(DIVA_CAPI_ADAPTER * a)
/* functions for all parameters sent in INDs */ /* functions for all parameters sent in INDs */
/*------------------------------------------------------------------*/ /*------------------------------------------------------------------*/
void IndParse(PLCI * plci, word * parms_id, byte ** parms, byte multiIEsize) static void IndParse(PLCI *plci, word *parms_id, byte **parms, byte multiIEsize)
{ {
word ploc; /* points to current location within packet */ word ploc; /* points to current location within packet */
byte w; byte w;
...@@ -8991,7 +8996,7 @@ void IndParse(PLCI * plci, word * parms_id, byte ** parms, byte multiIEsize) ...@@ -8991,7 +8996,7 @@ void IndParse(PLCI * plci, word * parms_id, byte ** parms, byte multiIEsize)
/* try to match a cip from received BC and HLC */ /* try to match a cip from received BC and HLC */
/*------------------------------------------------------------------*/ /*------------------------------------------------------------------*/
byte ie_compare(byte * ie1, byte * ie2) static byte ie_compare(byte *ie1, byte *ie2)
{ {
word i; word i;
if(!ie1 || ! ie2) return false; if(!ie1 || ! ie2) return false;
...@@ -9000,7 +9005,7 @@ byte ie_compare(byte * ie1, byte * ie2) ...@@ -9000,7 +9005,7 @@ byte ie_compare(byte * ie1, byte * ie2)
return true; return true;
} }
word find_cip(DIVA_CAPI_ADAPTER * a, byte * bc, byte * hlc) static word find_cip(DIVA_CAPI_ADAPTER *a, byte *bc, byte *hlc)
{ {
word i; word i;
word j; word j;
...@@ -9068,7 +9073,7 @@ static byte AddInfo(byte **add_i, ...@@ -9068,7 +9073,7 @@ static byte AddInfo(byte **add_i,
/* voice and codec features */ /* voice and codec features */
/*------------------------------------------------------------------*/ /*------------------------------------------------------------------*/
void SetVoiceChannel(PLCI *plci, byte *chi, DIVA_CAPI_ADAPTER * a) static void SetVoiceChannel(PLCI *plci, byte *chi, DIVA_CAPI_ADAPTER *a)
{ {
byte voice_chi[] = "\x02\x18\x01"; byte voice_chi[] = "\x02\x18\x01";
byte channel; byte channel;
...@@ -9086,7 +9091,7 @@ void SetVoiceChannel(PLCI *plci, byte *chi, DIVA_CAPI_ADAPTER * a) ...@@ -9086,7 +9091,7 @@ void SetVoiceChannel(PLCI *plci, byte *chi, DIVA_CAPI_ADAPTER * a)
} }
} }
void VoiceChannelOff(PLCI *plci) static void VoiceChannelOff(PLCI *plci)
{ {
dbug(1,dprintf("ExtDevOFF")); dbug(1,dprintf("ExtDevOFF"));
add_p(plci,FTY,"\x02\x01\x08"); /* B Off */ add_p(plci,FTY,"\x02\x01\x08"); /* B Off */
...@@ -9099,7 +9104,8 @@ void VoiceChannelOff(PLCI *plci) ...@@ -9099,7 +9104,8 @@ void VoiceChannelOff(PLCI *plci)
} }
word AdvCodecSupport(DIVA_CAPI_ADAPTER *a, PLCI *plci, APPL *appl, byte hook_listen) static word AdvCodecSupport(DIVA_CAPI_ADAPTER *a, PLCI *plci, APPL *appl,
byte hook_listen)
{ {
word j; word j;
PLCI *splci; PLCI *splci;
...@@ -9195,7 +9201,7 @@ word AdvCodecSupport(DIVA_CAPI_ADAPTER *a, PLCI *plci, APPL *appl, byte ho ...@@ -9195,7 +9201,7 @@ word AdvCodecSupport(DIVA_CAPI_ADAPTER *a, PLCI *plci, APPL *appl, byte ho
} }
void CodecIdCheck(DIVA_CAPI_ADAPTER *a, PLCI *plci) static void CodecIdCheck(DIVA_CAPI_ADAPTER *a, PLCI *plci)
{ {
dbug(1,dprintf("CodecIdCheck")); dbug(1,dprintf("CodecIdCheck"));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7