Commit 4f4374a9 authored by Miklos Szeredi's avatar Miklos Szeredi Committed by Greg Kroah-Hartman

vfs: fix freeze protection in mnt_want_write_file() for overlayfs

[ Upstream commit a6795a58 ]

The underlying real file used by overlayfs still contains the overlay path.
This results in mnt_want_write_file() calls by the filesystem getting
freeze protection on the wrong inode (the overlayfs one instead of the real
one).

Fix by using file_inode(file)->i_sb instead of file->f_path.mnt->mnt_sb.
Reported-by: default avatarAmir Goldstein <amir73il@gmail.com>
Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b888dba2
...@@ -446,10 +446,10 @@ int mnt_want_write_file_path(struct file *file) ...@@ -446,10 +446,10 @@ int mnt_want_write_file_path(struct file *file)
{ {
int ret; int ret;
sb_start_write(file->f_path.mnt->mnt_sb); sb_start_write(file_inode(file)->i_sb);
ret = __mnt_want_write_file(file); ret = __mnt_want_write_file(file);
if (ret) if (ret)
sb_end_write(file->f_path.mnt->mnt_sb); sb_end_write(file_inode(file)->i_sb);
return ret; return ret;
} }
...@@ -540,7 +540,8 @@ void __mnt_drop_write_file(struct file *file) ...@@ -540,7 +540,8 @@ void __mnt_drop_write_file(struct file *file)
void mnt_drop_write_file_path(struct file *file) void mnt_drop_write_file_path(struct file *file)
{ {
mnt_drop_write(file->f_path.mnt); __mnt_drop_write_file(file);
sb_end_write(file_inode(file)->i_sb);
} }
void mnt_drop_write_file(struct file *file) void mnt_drop_write_file(struct file *file)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment