Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
L
linux
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
linux
Commits
4f51388a
Commit
4f51388a
authored
Mar 21, 2004
by
Martin Devera
Committed by
Linus Torvalds
Mar 21, 2004
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[NET_SCHED]: HTB scheduler updates.
Fixes: * Fix to htb_requeue routine. * Debug mode related oops fixes.
parent
87471ca3
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
14 additions
and
10 deletions
+14
-10
net/sched/sch_htb.c
net/sched/sch_htb.c
+14
-10
No files found.
net/sched/sch_htb.c
View file @
4f51388a
...
@@ -21,9 +21,11 @@
...
@@ -21,9 +21,11 @@
* created test case so that I was able to fix nasty bug
* created test case so that I was able to fix nasty bug
* Wilfried Weissmann
* Wilfried Weissmann
* spotted bug in dequeue code and helped with fix
* spotted bug in dequeue code and helped with fix
* Jiri Fojtasek
* fixed requeue routine
* and many others. thanks.
* and many others. thanks.
*
*
* $Id: sch_htb.c,v 1.2
4 2003/07/28 15:25:23
devik Exp devik $
* $Id: sch_htb.c,v 1.2
5 2003/12/07 11:08:25
devik Exp devik $
*/
*/
#include <linux/config.h>
#include <linux/config.h>
#include <linux/module.h>
#include <linux/module.h>
...
@@ -74,7 +76,7 @@
...
@@ -74,7 +76,7 @@
#define HTB_HYSTERESIS 1
/* whether to use mode hysteresis for speedup */
#define HTB_HYSTERESIS 1
/* whether to use mode hysteresis for speedup */
#define HTB_QLOCK(S) spin_lock_bh(&(S)->dev->queue_lock)
#define HTB_QLOCK(S) spin_lock_bh(&(S)->dev->queue_lock)
#define HTB_QUNLOCK(S) spin_unlock_bh(&(S)->dev->queue_lock)
#define HTB_QUNLOCK(S) spin_unlock_bh(&(S)->dev->queue_lock)
#define HTB_VER 0x300
0f
/* major must be matched with number suplied by TC as version */
#define HTB_VER 0x300
10
/* major must be matched with number suplied by TC as version */
#if HTB_VER >> 16 != TC_HTB_PROTOVER
#if HTB_VER >> 16 != TC_HTB_PROTOVER
#error "Mismatched sch_htb.c and pkt_sch.h"
#error "Mismatched sch_htb.c and pkt_sch.h"
...
@@ -708,7 +710,7 @@ static int htb_enqueue(struct sk_buff *skb, struct Qdisc *sch)
...
@@ -708,7 +710,7 @@ static int htb_enqueue(struct sk_buff *skb, struct Qdisc *sch)
sch
->
q
.
qlen
++
;
sch
->
q
.
qlen
++
;
sch
->
stats
.
packets
++
;
sch
->
stats
.
bytes
+=
skb
->
len
;
sch
->
stats
.
packets
++
;
sch
->
stats
.
bytes
+=
skb
->
len
;
HTB_DBG
(
1
,
1
,
"htb_enq_ok cl=%X skb=%p
\n
"
,
htb_classid
(
cl
)
,
skb
);
HTB_DBG
(
1
,
1
,
"htb_enq_ok cl=%X skb=%p
\n
"
,
(
cl
&&
cl
!=
HTB_DIRECT
)
?
cl
->
classid
:
0
,
skb
);
return
NET_XMIT_SUCCESS
;
return
NET_XMIT_SUCCESS
;
}
}
...
@@ -717,16 +719,18 @@ static int htb_requeue(struct sk_buff *skb, struct Qdisc *sch)
...
@@ -717,16 +719,18 @@ static int htb_requeue(struct sk_buff *skb, struct Qdisc *sch)
{
{
struct
htb_sched
*
q
=
(
struct
htb_sched
*
)
sch
->
data
;
struct
htb_sched
*
q
=
(
struct
htb_sched
*
)
sch
->
data
;
struct
htb_class
*
cl
=
htb_classify
(
skb
,
sch
);
struct
htb_class
*
cl
=
htb_classify
(
skb
,
sch
);
struct
sk_buff
*
tskb
;
if
(
cl
==
HTB_DIRECT
||
!
cl
)
{
if
(
cl
==
HTB_DIRECT
||
!
cl
)
{
/* enqueue to helper queue */
/* enqueue to helper queue */
if
(
q
->
direct_queue
.
qlen
<
q
->
direct_qlen
&&
cl
)
{
if
(
q
->
direct_queue
.
qlen
<
q
->
direct_qlen
&&
cl
)
{
__skb_queue_tail
(
&
q
->
direct_queue
,
skb
);
__skb_queue_head
(
&
q
->
direct_queue
,
skb
);
q
->
direct_pkts
++
;
}
else
{
}
else
{
kfree_skb
(
skb
);
__skb_queue_head
(
&
q
->
direct_queue
,
skb
);
sch
->
stats
.
drops
++
;
tskb
=
__skb_dequeue_tail
(
&
q
->
direct_queue
);
return
NET_XMIT_DROP
;
kfree_skb
(
tskb
);
sch
->
stats
.
drops
++
;
return
NET_XMIT_CN
;
}
}
}
else
if
(
cl
->
un
.
leaf
.
q
->
ops
->
requeue
(
skb
,
cl
->
un
.
leaf
.
q
)
!=
NET_XMIT_SUCCESS
)
{
}
else
if
(
cl
->
un
.
leaf
.
q
->
ops
->
requeue
(
skb
,
cl
->
un
.
leaf
.
q
)
!=
NET_XMIT_SUCCESS
)
{
sch
->
stats
.
drops
++
;
sch
->
stats
.
drops
++
;
...
@@ -736,7 +740,7 @@ static int htb_requeue(struct sk_buff *skb, struct Qdisc *sch)
...
@@ -736,7 +740,7 @@ static int htb_requeue(struct sk_buff *skb, struct Qdisc *sch)
htb_activate
(
q
,
cl
);
htb_activate
(
q
,
cl
);
sch
->
q
.
qlen
++
;
sch
->
q
.
qlen
++
;
HTB_DBG
(
1
,
1
,
"htb_req_ok cl=%X skb=%p
\n
"
,
htb_classid
(
cl
)
,
skb
);
HTB_DBG
(
1
,
1
,
"htb_req_ok cl=%X skb=%p
\n
"
,
(
cl
&&
cl
!=
HTB_DIRECT
)
?
cl
->
classid
:
0
,
skb
);
return
NET_XMIT_SUCCESS
;
return
NET_XMIT_SUCCESS
;
}
}
...
@@ -1487,7 +1491,7 @@ static int htb_change_class(struct Qdisc *sch, u32 classid,
...
@@ -1487,7 +1491,7 @@ static int htb_change_class(struct Qdisc *sch, u32 classid,
cl
->
magic
=
HTB_CMAGIC
;
cl
->
magic
=
HTB_CMAGIC
;
#endif
#endif
/* create leaf qdisc early because it uses kmalloc(G
PF
_KERNEL)
/* create leaf qdisc early because it uses kmalloc(G
FP
_KERNEL)
so that can't be used inside of sch_tree_lock
so that can't be used inside of sch_tree_lock
-- thanks to Karlis Peisenieks */
-- thanks to Karlis Peisenieks */
new_q
=
qdisc_create_dflt
(
sch
->
dev
,
&
pfifo_qdisc_ops
);
new_q
=
qdisc_create_dflt
(
sch
->
dev
,
&
pfifo_qdisc_ops
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment