Commit 4f532c1e authored by Pali Rohár's avatar Pali Rohár Committed by Greg Kroah-Hartman

serial: mvebu-uart: correctly report configured baudrate value

Functions tty_termios_encode_baud_rate() and uart_update_timeout() should
be called with the baudrate value which was set to hardware. Linux then
report exact values via ioctl(TCGETS2) to userspace.

Change mvebu_uart_baud_rate_set() function to return baudrate value which
was set to hardware and propagate this value to above mentioned functions.

With this change userspace would see precise value in termios c_ospeed
field.

Fixes: 68a0db1d ("serial: mvebu-uart: add function to change baudrate")
Cc: stable <stable@kernel.org>
Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarPali Rohár <pali@kernel.org>
Link: https://lore.kernel.org/r/20220628100922.10717-1-pali@kernel.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f9b11229
...@@ -470,14 +470,14 @@ static void mvebu_uart_shutdown(struct uart_port *port) ...@@ -470,14 +470,14 @@ static void mvebu_uart_shutdown(struct uart_port *port)
} }
} }
static int mvebu_uart_baud_rate_set(struct uart_port *port, unsigned int baud) static unsigned int mvebu_uart_baud_rate_set(struct uart_port *port, unsigned int baud)
{ {
unsigned int d_divisor, m_divisor; unsigned int d_divisor, m_divisor;
unsigned long flags; unsigned long flags;
u32 brdv, osamp; u32 brdv, osamp;
if (!port->uartclk) if (!port->uartclk)
return -EOPNOTSUPP; return 0;
/* /*
* The baudrate is derived from the UART clock thanks to divisors: * The baudrate is derived from the UART clock thanks to divisors:
...@@ -548,7 +548,7 @@ static int mvebu_uart_baud_rate_set(struct uart_port *port, unsigned int baud) ...@@ -548,7 +548,7 @@ static int mvebu_uart_baud_rate_set(struct uart_port *port, unsigned int baud)
(m_divisor << 16) | (m_divisor << 24); (m_divisor << 16) | (m_divisor << 24);
writel(osamp, port->membase + UART_OSAMP); writel(osamp, port->membase + UART_OSAMP);
return 0; return DIV_ROUND_CLOSEST(port->uartclk, d_divisor * m_divisor);
} }
static void mvebu_uart_set_termios(struct uart_port *port, static void mvebu_uart_set_termios(struct uart_port *port,
...@@ -587,15 +587,11 @@ static void mvebu_uart_set_termios(struct uart_port *port, ...@@ -587,15 +587,11 @@ static void mvebu_uart_set_termios(struct uart_port *port,
max_baud = port->uartclk / 80; max_baud = port->uartclk / 80;
baud = uart_get_baud_rate(port, termios, old, min_baud, max_baud); baud = uart_get_baud_rate(port, termios, old, min_baud, max_baud);
if (mvebu_uart_baud_rate_set(port, baud)) { baud = mvebu_uart_baud_rate_set(port, baud);
/* No clock available, baudrate cannot be changed */
if (old) /* In case baudrate cannot be changed, report previous old value */
baud = uart_get_baud_rate(port, old, NULL, if (baud == 0 && old)
min_baud, max_baud); baud = tty_termios_baud_rate(old);
} else {
tty_termios_encode_baud_rate(termios, baud, baud);
uart_update_timeout(port, termios->c_cflag, baud);
}
/* Only the following flag changes are supported */ /* Only the following flag changes are supported */
if (old) { if (old) {
...@@ -606,6 +602,11 @@ static void mvebu_uart_set_termios(struct uart_port *port, ...@@ -606,6 +602,11 @@ static void mvebu_uart_set_termios(struct uart_port *port,
termios->c_cflag |= CS8; termios->c_cflag |= CS8;
} }
if (baud != 0) {
tty_termios_encode_baud_rate(termios, baud, baud);
uart_update_timeout(port, termios->c_cflag, baud);
}
spin_unlock_irqrestore(&port->lock, flags); spin_unlock_irqrestore(&port->lock, flags);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment