Commit 4fcdaf6e authored by Chris Lew's avatar Chris Lew Committed by Bjorn Andersson

rpmsg: glink: Use complete_all for open states

The open_req and open_ack completion variables are the state variables
to represet a remote channel as open. Use complete_all so there are no
races with waiters and using completion_done.
Signed-off-by: default avatarChris Lew <clew@codeaurora.org>
Signed-off-by: default avatarArun Kumar Neelakantam <aneela@codeaurora.org>
Signed-off-by: default avatarDeepak Kumar Singh <deesin@codeaurora.org>
Link: https://lore.kernel.org/r/1593017121-7953-2-git-send-email-deesin@codeaurora.orgSigned-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
parent 6c09ea0b
...@@ -970,7 +970,7 @@ static int qcom_glink_rx_open_ack(struct qcom_glink *glink, unsigned int lcid) ...@@ -970,7 +970,7 @@ static int qcom_glink_rx_open_ack(struct qcom_glink *glink, unsigned int lcid)
return -EINVAL; return -EINVAL;
} }
complete(&channel->open_ack); complete_all(&channel->open_ack);
return 0; return 0;
} }
...@@ -1178,7 +1178,7 @@ static int qcom_glink_announce_create(struct rpmsg_device *rpdev) ...@@ -1178,7 +1178,7 @@ static int qcom_glink_announce_create(struct rpmsg_device *rpdev)
__be32 *val = defaults; __be32 *val = defaults;
int size; int size;
if (glink->intentless) if (glink->intentless || !completion_done(&channel->open_ack))
return 0; return 0;
prop = of_find_property(np, "qcom,intents", NULL); prop = of_find_property(np, "qcom,intents", NULL);
...@@ -1413,7 +1413,7 @@ static int qcom_glink_rx_open(struct qcom_glink *glink, unsigned int rcid, ...@@ -1413,7 +1413,7 @@ static int qcom_glink_rx_open(struct qcom_glink *glink, unsigned int rcid,
channel->rcid = ret; channel->rcid = ret;
spin_unlock_irqrestore(&glink->idr_lock, flags); spin_unlock_irqrestore(&glink->idr_lock, flags);
complete(&channel->open_req); complete_all(&channel->open_req);
if (create_device) { if (create_device) {
rpdev = kzalloc(sizeof(*rpdev), GFP_KERNEL); rpdev = kzalloc(sizeof(*rpdev), GFP_KERNEL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment