Commit 5036eaff authored by Ilan Peer's avatar Ilan Peer Committed by Johannes Berg

wifi: cfg80211: Always call tracing

Call the tracing function even if the cfg80211 callbacks
are not set. This would allow better understanding of
user space actions.
Reviewed-by: default avatarMiriam Rachel Korenblit <miriam.rachel.korenblit@intel.com>
Signed-off-by: default avatarIlan Peer <ilan.peer@intel.com>
Link: https://patch.msgid.link/20240614093541.018cb816e176.I28f68740a6b42144346f5c175c7874b0a669a364@changeidSigned-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 9cc88678
...@@ -578,13 +578,11 @@ static inline int rdev_leave_ibss(struct cfg80211_registered_device *rdev, ...@@ -578,13 +578,11 @@ static inline int rdev_leave_ibss(struct cfg80211_registered_device *rdev,
static inline int static inline int
rdev_set_wiphy_params(struct cfg80211_registered_device *rdev, u32 changed) rdev_set_wiphy_params(struct cfg80211_registered_device *rdev, u32 changed)
{ {
int ret; int ret = -EOPNOTSUPP;
if (!rdev->ops->set_wiphy_params)
return -EOPNOTSUPP;
trace_rdev_set_wiphy_params(&rdev->wiphy, changed); trace_rdev_set_wiphy_params(&rdev->wiphy, changed);
ret = rdev->ops->set_wiphy_params(&rdev->wiphy, changed); if (rdev->ops->set_wiphy_params)
ret = rdev->ops->set_wiphy_params(&rdev->wiphy, changed);
trace_rdev_return_int(&rdev->wiphy, ret); trace_rdev_return_int(&rdev->wiphy, ret);
return ret; return ret;
} }
...@@ -1425,13 +1423,11 @@ rdev_set_radar_background(struct cfg80211_registered_device *rdev, ...@@ -1425,13 +1423,11 @@ rdev_set_radar_background(struct cfg80211_registered_device *rdev,
struct cfg80211_chan_def *chandef) struct cfg80211_chan_def *chandef)
{ {
struct wiphy *wiphy = &rdev->wiphy; struct wiphy *wiphy = &rdev->wiphy;
int ret; int ret = -EOPNOTSUPP;
if (!rdev->ops->set_radar_background)
return -EOPNOTSUPP;
trace_rdev_set_radar_background(wiphy, chandef); trace_rdev_set_radar_background(wiphy, chandef);
ret = rdev->ops->set_radar_background(wiphy, chandef); if (rdev->ops->set_radar_background)
ret = rdev->ops->set_radar_background(wiphy, chandef);
trace_rdev_return_int(wiphy, ret); trace_rdev_return_int(wiphy, ret);
return ret; return ret;
...@@ -1468,13 +1464,11 @@ rdev_add_link_station(struct cfg80211_registered_device *rdev, ...@@ -1468,13 +1464,11 @@ rdev_add_link_station(struct cfg80211_registered_device *rdev,
struct net_device *dev, struct net_device *dev,
struct link_station_parameters *params) struct link_station_parameters *params)
{ {
int ret; int ret = -EOPNOTSUPP;
if (!rdev->ops->add_link_station)
return -EOPNOTSUPP;
trace_rdev_add_link_station(&rdev->wiphy, dev, params); trace_rdev_add_link_station(&rdev->wiphy, dev, params);
ret = rdev->ops->add_link_station(&rdev->wiphy, dev, params); if (rdev->ops->add_link_station)
ret = rdev->ops->add_link_station(&rdev->wiphy, dev, params);
trace_rdev_return_int(&rdev->wiphy, ret); trace_rdev_return_int(&rdev->wiphy, ret);
return ret; return ret;
} }
...@@ -1484,13 +1478,11 @@ rdev_mod_link_station(struct cfg80211_registered_device *rdev, ...@@ -1484,13 +1478,11 @@ rdev_mod_link_station(struct cfg80211_registered_device *rdev,
struct net_device *dev, struct net_device *dev,
struct link_station_parameters *params) struct link_station_parameters *params)
{ {
int ret; int ret = -EOPNOTSUPP;
if (!rdev->ops->mod_link_station)
return -EOPNOTSUPP;
trace_rdev_mod_link_station(&rdev->wiphy, dev, params); trace_rdev_mod_link_station(&rdev->wiphy, dev, params);
ret = rdev->ops->mod_link_station(&rdev->wiphy, dev, params); if (rdev->ops->mod_link_station)
ret = rdev->ops->mod_link_station(&rdev->wiphy, dev, params);
trace_rdev_return_int(&rdev->wiphy, ret); trace_rdev_return_int(&rdev->wiphy, ret);
return ret; return ret;
} }
...@@ -1500,13 +1492,11 @@ rdev_del_link_station(struct cfg80211_registered_device *rdev, ...@@ -1500,13 +1492,11 @@ rdev_del_link_station(struct cfg80211_registered_device *rdev,
struct net_device *dev, struct net_device *dev,
struct link_station_del_parameters *params) struct link_station_del_parameters *params)
{ {
int ret; int ret = -EOPNOTSUPP;
if (!rdev->ops->del_link_station)
return -EOPNOTSUPP;
trace_rdev_del_link_station(&rdev->wiphy, dev, params); trace_rdev_del_link_station(&rdev->wiphy, dev, params);
ret = rdev->ops->del_link_station(&rdev->wiphy, dev, params); if (rdev->ops->del_link_station)
ret = rdev->ops->del_link_station(&rdev->wiphy, dev, params);
trace_rdev_return_int(&rdev->wiphy, ret); trace_rdev_return_int(&rdev->wiphy, ret);
return ret; return ret;
} }
...@@ -1517,13 +1507,11 @@ rdev_set_hw_timestamp(struct cfg80211_registered_device *rdev, ...@@ -1517,13 +1507,11 @@ rdev_set_hw_timestamp(struct cfg80211_registered_device *rdev,
struct cfg80211_set_hw_timestamp *hwts) struct cfg80211_set_hw_timestamp *hwts)
{ {
struct wiphy *wiphy = &rdev->wiphy; struct wiphy *wiphy = &rdev->wiphy;
int ret; int ret = -EOPNOTSUPP;
if (!rdev->ops->set_hw_timestamp)
return -EOPNOTSUPP;
trace_rdev_set_hw_timestamp(wiphy, dev, hwts); trace_rdev_set_hw_timestamp(wiphy, dev, hwts);
ret = rdev->ops->set_hw_timestamp(wiphy, dev, hwts); if (rdev->ops->set_hw_timestamp)
ret = rdev->ops->set_hw_timestamp(wiphy, dev, hwts);
trace_rdev_return_int(wiphy, ret); trace_rdev_return_int(wiphy, ret);
return ret; return ret;
...@@ -1535,13 +1523,11 @@ rdev_set_ttlm(struct cfg80211_registered_device *rdev, ...@@ -1535,13 +1523,11 @@ rdev_set_ttlm(struct cfg80211_registered_device *rdev,
struct cfg80211_ttlm_params *params) struct cfg80211_ttlm_params *params)
{ {
struct wiphy *wiphy = &rdev->wiphy; struct wiphy *wiphy = &rdev->wiphy;
int ret; int ret = -EOPNOTSUPP;
if (!rdev->ops->set_ttlm)
return -EOPNOTSUPP;
trace_rdev_set_ttlm(wiphy, dev, params); trace_rdev_set_ttlm(wiphy, dev, params);
ret = rdev->ops->set_ttlm(wiphy, dev, params); if (rdev->ops->set_ttlm)
ret = rdev->ops->set_ttlm(wiphy, dev, params);
trace_rdev_return_int(wiphy, ret); trace_rdev_return_int(wiphy, ret);
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment