Commit 50515cac authored by Jean Sacren's avatar Jean Sacren Committed by Jakub Kicinski

net: qed_debug: fix check of false (grc_param < 0) expression

The type of enum dbg_grc_params has the enumerator list starting from 0.
When grc_param is declared by enum dbg_grc_params, (grc_param < 0) is
always false.  We should remove the check of this expression.
Signed-off-by: default avatarJean Sacren <sakiwit@gmail.com>
Acked-by: default avatarShai Malin <smalin@marvell.com>
Link: https://lore.kernel.org/r/20211012074645.12864-1-sakiwit@gmail.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent edce2a93
...@@ -5256,7 +5256,7 @@ enum dbg_status qed_dbg_grc_config(struct qed_hwfn *p_hwfn, ...@@ -5256,7 +5256,7 @@ enum dbg_status qed_dbg_grc_config(struct qed_hwfn *p_hwfn,
*/ */
qed_dbg_grc_init_params(p_hwfn); qed_dbg_grc_init_params(p_hwfn);
if (grc_param >= MAX_DBG_GRC_PARAMS || grc_param < 0) if (grc_param >= MAX_DBG_GRC_PARAMS)
return DBG_STATUS_INVALID_ARGS; return DBG_STATUS_INVALID_ARGS;
if (val < s_grc_param_defs[grc_param].min || if (val < s_grc_param_defs[grc_param].min ||
val > s_grc_param_defs[grc_param].max) val > s_grc_param_defs[grc_param].max)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment