Commit 505ecd35 authored by Yong Zhi's avatar Yong Zhi Committed by Mauro Carvalho Chehab

media: ipu3-imgu: Remove dead code for NULL check

Since ipu3_css_buf_dequeue() never returns NULL, remove the
dead code to fix static checker warning:

drivers/staging/media/ipu3/ipu3.c:493 imgu_isr_threaded()
warn: 'b' is an error pointer or valid
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
[Bug report: https://lore.kernel.org/linux-media/20190104122856.GA1169@kadam/]
Signed-off-by: default avatarYong Zhi <yong.zhi@intel.com>
Reviewed-by: default avatarTomasz Figa <tfiga@chromium.org>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 041bc406
...@@ -489,12 +489,11 @@ static irqreturn_t imgu_isr_threaded(int irq, void *imgu_ptr) ...@@ -489,12 +489,11 @@ static irqreturn_t imgu_isr_threaded(int irq, void *imgu_ptr)
mutex_unlock(&imgu->lock); mutex_unlock(&imgu->lock);
} while (PTR_ERR(b) == -EAGAIN); } while (PTR_ERR(b) == -EAGAIN);
if (IS_ERR_OR_NULL(b)) { if (IS_ERR(b)) {
if (!b || PTR_ERR(b) == -EBUSY) /* All done */ if (PTR_ERR(b) != -EBUSY) /* All done */
break; dev_err(&imgu->pci_dev->dev,
dev_err(&imgu->pci_dev->dev, "failed to dequeue buffers (%ld)\n",
"failed to dequeue buffers (%ld)\n", PTR_ERR(b));
PTR_ERR(b));
break; break;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment