Commit 5092450c authored by Aya Mahfouz's avatar Aya Mahfouz Committed by Greg Kroah-Hartman

staging: rtl8723au: hal: rewrite the right hand side of an assignment

This patch rewrites the right hand side of an assignment for
expressions of the form:
a = (a <op> b);
to be:
a <op>= b;
where <op> = << | >>.

This issue was detected and resolved using the following
coccinelle script:

@@
identifier i;
expression e;
@@

-i = (i >> e);
+i >>= e;

@@
identifier i;
expression e;
@@

-i = (i << e);
+i <<= e;
Signed-off-by: default avatarAya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a9dbc808
...@@ -30,12 +30,12 @@ static bool CheckCondition(const u32 Condition, const u32 Hex) ...@@ -30,12 +30,12 @@ static bool CheckCondition(const u32 Condition, const u32 Hex)
return false; return false;
cond = Condition & 0x0000FF00; cond = Condition & 0x0000FF00;
cond = cond >> 8; cond >>= 8;
if ((_interface & cond) == 0 && cond != 0x07) if ((_interface & cond) == 0 && cond != 0x07)
return false; return false;
cond = Condition & 0x00FF0000; cond = Condition & 0x00FF0000;
cond = cond >> 16; cond >>= 16;
if ((_platform & cond) == 0 && cond != 0x0F) if ((_platform & cond) == 0 && cond != 0x0F)
return false; return false;
return true; return true;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment