Commit 509eaa8a authored by Douglas Anderson's avatar Douglas Anderson Committed by Neil Armstrong

drm/panel: himax-hx83102: If prepare fails, disable GPIO before regulators

The enable GPIO should clearly be set low before turning off
regulators. That matches both the inverse order that things were
enabled and also the order in unprepare().

Fixes: 0ef94554 ("drm/panel: himax-hx83102: Break out as separate driver")
Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20240517143643.6.Id0659a80147cf51e0ebb8fe7fee18db86851960d@changeidSigned-off-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240517143643.6.Id0659a80147cf51e0ebb8fe7fee18db86851960d@changeid
parent 6a7bd6cd
...@@ -578,13 +578,13 @@ static int hx83102_prepare(struct drm_panel *panel) ...@@ -578,13 +578,13 @@ static int hx83102_prepare(struct drm_panel *panel)
return 0; return 0;
poweroff: poweroff:
gpiod_set_value(ctx->enable_gpio, 0);
regulator_disable(ctx->avee); regulator_disable(ctx->avee);
poweroffavdd: poweroffavdd:
regulator_disable(ctx->avdd); regulator_disable(ctx->avdd);
poweroff1v8: poweroff1v8:
usleep_range(5000, 7000); usleep_range(5000, 7000);
regulator_disable(ctx->pp1800); regulator_disable(ctx->pp1800);
gpiod_set_value(ctx->enable_gpio, 0);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment