Commit 514e59c1 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Martin K. Petersen

scsi: fnic: fix format string overflow warning

The MSI interrupt name can require 11 bytes in addition to the device name,
for a total of 23 bytes:

drivers/scsi/fnic/fnic_isr.c: In function 'fnic_request_intr':
drivers/scsi/fnic/fnic_isr.c:192:4: error: '-fcs-rq' directive writing 7 bytes into a region of size between 5 and 16 [-Werror=format-overflow=]
    "%.11s-fcs-rq", fnic->name);
drivers/scsi/fnic/fnic_isr.c:206:3: note: 'sprintf' output between 12 and 23 bytes into a destination of size 16
   sprintf(fnic->msix[FNIC_MSIX_ERR_NOTIFY].devname,
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    "%.11s-err-notify", fnic->name);

This extends the buffer to fit any possible value.
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 0606ffe2
...@@ -180,7 +180,7 @@ enum fnic_msix_intr_index { ...@@ -180,7 +180,7 @@ enum fnic_msix_intr_index {
struct fnic_msix_entry { struct fnic_msix_entry {
int requested; int requested;
char devname[IFNAMSIZ]; char devname[IFNAMSIZ + 11];
irqreturn_t (*isr)(int, void *); irqreturn_t (*isr)(int, void *);
void *devid; void *devid;
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment