Commit 525b108e authored by DENG Qingfang's avatar DENG Qingfang Committed by David S. Miller

net: phy: mediatek: remove PHY mode check on MT7531

The function mt7531_phy_mode_supported in the DSA driver set supported
mode to PHY_INTERFACE_MODE_GMII instead of PHY_INTERFACE_MODE_INTERNAL
for the internal PHY, so this check breaks the PHY initialization:

mt7530 mdio-bus:00 wan (uninitialized): failed to connect to PHY: -EINVAL

Remove the check to make it work again.
Reported-by: default avatarHauke Mehrtens <hauke@hauke-m.de>
Fixes: e40d2cca ("net: phy: add MediaTek Gigabit Ethernet PHY driver")
Signed-off-by: default avatarDENG Qingfang <dqfext@gmail.com>
Acked-by: default avatarArınç ÜNAL <arinc.unal@arinc9.com>
Tested-by: default avatarHauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 032062f3
...@@ -55,9 +55,6 @@ static int mt7530_phy_config_init(struct phy_device *phydev) ...@@ -55,9 +55,6 @@ static int mt7530_phy_config_init(struct phy_device *phydev)
static int mt7531_phy_config_init(struct phy_device *phydev) static int mt7531_phy_config_init(struct phy_device *phydev)
{ {
if (phydev->interface != PHY_INTERFACE_MODE_INTERNAL)
return -EINVAL;
mtk_gephy_config_init(phydev); mtk_gephy_config_init(phydev);
/* PHY link down power saving enable */ /* PHY link down power saving enable */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment