Commit 5290e88b authored by Steve Wahl's avatar Steve Wahl Committed by Dave Hansen

x86/platform/uv: Use alternate source for socket to node data

The UV code attempts to build a set of tables to allow it to do
bidirectional socket<=>node lookups.

But when nr_cpus is set to a smaller number than actually present, the
cpu_to_node() mapping information for unused CPUs is not available to
build_socket_tables(). This results in skipping some nodes or sockets
when creating the tables and leaving some -1's for later code to trip.
over, causing oopses.

The problem is that the socket<=>node lookups are created by doing a
loop over all CPUs, then looking up the CPU's APICID and socket. But
if a CPU is not present, there is no way to start this lookup.

Instead of looping over all CPUs, take CPUs out of the equation
entirely. Loop over all APICIDs which are mapped to a valid NUMA node.
Then just extract the socket-id from the APICID.

This avoid tripping over disabled CPUs.

Fixes: 8a50c585 ("x86/platform/uv: UV support for sub-NUMA clustering")
Signed-off-by: default avatarSteve Wahl <steve.wahl@hpe.com>
Signed-off-by: default avatarDave Hansen <dave.hansen@linux.intel.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/all/20230807141730.1117278-1-steve.wahl%40hpe.com
parent 0bb80ecc
...@@ -1533,7 +1533,7 @@ static void __init build_socket_tables(void) ...@@ -1533,7 +1533,7 @@ static void __init build_socket_tables(void)
{ {
struct uv_gam_range_entry *gre = uv_gre_table; struct uv_gam_range_entry *gre = uv_gre_table;
int nums, numn, nump; int nums, numn, nump;
int cpu, i, lnid; int i, lnid, apicid;
int minsock = _min_socket; int minsock = _min_socket;
int maxsock = _max_socket; int maxsock = _max_socket;
int minpnode = _min_pnode; int minpnode = _min_pnode;
...@@ -1584,15 +1584,14 @@ static void __init build_socket_tables(void) ...@@ -1584,15 +1584,14 @@ static void __init build_socket_tables(void)
/* Set socket -> node values: */ /* Set socket -> node values: */
lnid = NUMA_NO_NODE; lnid = NUMA_NO_NODE;
for_each_possible_cpu(cpu) { for (apicid = 0; apicid < ARRAY_SIZE(__apicid_to_node); apicid++) {
int nid = cpu_to_node(cpu); int nid = __apicid_to_node[apicid];
int apicid, sockid; int sockid;
if (lnid == nid) if ((nid == NUMA_NO_NODE) || (lnid == nid))
continue; continue;
lnid = nid; lnid = nid;
apicid = per_cpu(x86_cpu_to_apicid, cpu);
sockid = apicid >> uv_cpuid.socketid_shift; sockid = apicid >> uv_cpuid.socketid_shift;
if (_socket_to_node[sockid - minsock] == SOCK_EMPTY) if (_socket_to_node[sockid - minsock] == SOCK_EMPTY)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment