Commit 52db0f2b authored by Dmitry Baryshkov's avatar Dmitry Baryshkov

drm/msm/dpu: remove always-true argument of dpu_core_irq_read()

The argument clear of the function dpu_core_irq_read() is always true.
Remove it.
Reviewed-by: default avatarAbhinav Kumar <quic_abhinavk@quicinc.com>
Reviewed-by: default avatarStephen Boyd <swboyd@chromium.org>
Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/474697/
Link: https://lore.kernel.org/r/20220217043148.480898-3-dmitry.baryshkov@linaro.orgSigned-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
parent dd77ce4d
...@@ -33,13 +33,11 @@ irqreturn_t dpu_core_irq(struct msm_kms *kms); ...@@ -33,13 +33,11 @@ irqreturn_t dpu_core_irq(struct msm_kms *kms);
* dpu_core_irq_read - IRQ helper function for reading IRQ status * dpu_core_irq_read - IRQ helper function for reading IRQ status
* @dpu_kms: DPU handle * @dpu_kms: DPU handle
* @irq_idx: irq index * @irq_idx: irq index
* @clear: True to clear the irq after read
* @return: non-zero if irq detected; otherwise no irq detected * @return: non-zero if irq detected; otherwise no irq detected
*/ */
u32 dpu_core_irq_read( u32 dpu_core_irq_read(
struct dpu_kms *dpu_kms, struct dpu_kms *dpu_kms,
int irq_idx, int irq_idx);
bool clear);
/** /**
* dpu_core_irq_register_callback - For registering callback function on IRQ * dpu_core_irq_register_callback - For registering callback function on IRQ
......
...@@ -318,8 +318,7 @@ int dpu_encoder_helper_wait_for_irq(struct dpu_encoder_phys *phys_enc, ...@@ -318,8 +318,7 @@ int dpu_encoder_helper_wait_for_irq(struct dpu_encoder_phys *phys_enc,
wait_info); wait_info);
if (ret <= 0) { if (ret <= 0) {
irq_status = dpu_core_irq_read(phys_enc->dpu_kms, irq_status = dpu_core_irq_read(phys_enc->dpu_kms, irq->irq_idx);
irq->irq_idx, true);
if (irq_status) { if (irq_status) {
unsigned long flags; unsigned long flags;
......
...@@ -363,7 +363,7 @@ static void dpu_disable_all_irqs(struct dpu_kms *dpu_kms) ...@@ -363,7 +363,7 @@ static void dpu_disable_all_irqs(struct dpu_kms *dpu_kms)
wmb(); wmb();
} }
u32 dpu_core_irq_read(struct dpu_kms *dpu_kms, int irq_idx, bool clear) u32 dpu_core_irq_read(struct dpu_kms *dpu_kms, int irq_idx)
{ {
struct dpu_hw_intr *intr = dpu_kms->hw_intr; struct dpu_hw_intr *intr = dpu_kms->hw_intr;
int reg_idx; int reg_idx;
...@@ -390,7 +390,7 @@ u32 dpu_core_irq_read(struct dpu_kms *dpu_kms, int irq_idx, bool clear) ...@@ -390,7 +390,7 @@ u32 dpu_core_irq_read(struct dpu_kms *dpu_kms, int irq_idx, bool clear)
intr_status = DPU_REG_READ(&intr->hw, intr_status = DPU_REG_READ(&intr->hw,
dpu_intr_set[reg_idx].status_off) & dpu_intr_set[reg_idx].status_off) &
DPU_IRQ_MASK(irq_idx); DPU_IRQ_MASK(irq_idx);
if (intr_status && clear) if (intr_status)
DPU_REG_WRITE(&intr->hw, dpu_intr_set[reg_idx].clr_off, DPU_REG_WRITE(&intr->hw, dpu_intr_set[reg_idx].clr_off,
intr_status); intr_status);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment