Commit 52fe51f8 authored by Wu Fengguang's avatar Wu Fengguang Committed by David S. Miller

ipv6: fix ifnullfree.cocci warnings

net/ipv6/route.c:2946:3-8: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

CC: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: default avatarFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 792aec47
...@@ -2942,7 +2942,6 @@ static int ip6_route_multipath_add(struct fib6_config *cfg) ...@@ -2942,7 +2942,6 @@ static int ip6_route_multipath_add(struct fib6_config *cfg)
list_for_each_entry_safe(nh, nh_safe, &rt6_nh_list, next) { list_for_each_entry_safe(nh, nh_safe, &rt6_nh_list, next) {
if (nh->rt6_info) if (nh->rt6_info)
dst_free(&nh->rt6_info->dst); dst_free(&nh->rt6_info->dst);
if (nh->mxc.mx)
kfree(nh->mxc.mx); kfree(nh->mxc.mx);
list_del(&nh->next); list_del(&nh->next);
kfree(nh); kfree(nh);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment