Commit 53b8d2be authored by Ruan Jinjie's avatar Ruan Jinjie Committed by Marc Kleine-Budde

can: flexcan: fix the return value handle for platform_get_irq()

There is no possible for platform_get_irq() to return 0
and the return value of platform_get_irq() is more sensible
to show the error reason.
Signed-off-by: default avatarRuan Jinjie <ruanjinjie@huawei.com>
Link: https://lore.kernel.org/all/20230731075252.359965-1-ruanjinjie@huawei.comSigned-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 2b3082c6
...@@ -2089,8 +2089,8 @@ static int flexcan_probe(struct platform_device *pdev) ...@@ -2089,8 +2089,8 @@ static int flexcan_probe(struct platform_device *pdev)
} }
irq = platform_get_irq(pdev, 0); irq = platform_get_irq(pdev, 0);
if (irq <= 0) if (irq < 0)
return -ENODEV; return irq;
regs = devm_platform_ioremap_resource(pdev, 0); regs = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(regs)) if (IS_ERR(regs))
...@@ -2167,13 +2167,13 @@ static int flexcan_probe(struct platform_device *pdev) ...@@ -2167,13 +2167,13 @@ static int flexcan_probe(struct platform_device *pdev)
if (priv->devtype_data.quirks & FLEXCAN_QUIRK_NR_IRQ_3) { if (priv->devtype_data.quirks & FLEXCAN_QUIRK_NR_IRQ_3) {
priv->irq_boff = platform_get_irq(pdev, 1); priv->irq_boff = platform_get_irq(pdev, 1);
if (priv->irq_boff <= 0) { if (priv->irq_boff < 0) {
err = -ENODEV; err = priv->irq_boff;
goto failed_platform_get_irq; goto failed_platform_get_irq;
} }
priv->irq_err = platform_get_irq(pdev, 2); priv->irq_err = platform_get_irq(pdev, 2);
if (priv->irq_err <= 0) { if (priv->irq_err < 0) {
err = -ENODEV; err = priv->irq_err;
goto failed_platform_get_irq; goto failed_platform_get_irq;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment