Commit 53e4d8c2 authored by David Sterba's avatar David Sterba

btrfs: change BUG_ON to assertion in reset_balance_state()

The balance state machine is complex so it's good to verify the
assumptions in helpers, however reset_balance_state() is used
at the end of balance and fs_info::balance_ctl is properly set up before
and protected by the exclusive op ownership in btrfs_balance().
Reviewed-by: default avatarJosef Bacik <josef@toxicpanda.com>
Reviewed-by: default avatarAnand Jain <anand.jain@oracle.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 3e1d51dd
...@@ -3632,7 +3632,7 @@ static void reset_balance_state(struct btrfs_fs_info *fs_info) ...@@ -3632,7 +3632,7 @@ static void reset_balance_state(struct btrfs_fs_info *fs_info)
struct btrfs_balance_control *bctl = fs_info->balance_ctl; struct btrfs_balance_control *bctl = fs_info->balance_ctl;
int ret; int ret;
BUG_ON(!fs_info->balance_ctl); ASSERT(fs_info->balance_ctl);
spin_lock(&fs_info->balance_lock); spin_lock(&fs_info->balance_lock);
fs_info->balance_ctl = NULL; fs_info->balance_ctl = NULL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment