Commit 5424ea27 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller

netns: get more entropy from net_hash_mix()

struct net are effectively allocated from order-1 pages on x86,
with one object per slab, meaning that the 13 low order bits
of their addresses are zero.

Once shifted by L1_CACHE_SHIFT, this leaves 7 zero-bits,
meaning that net_hash_mix() does not help spreading
objects on various hash tables.

For example, TCP listen table has 32 buckets, meaning that
all netns use the same bucket for port 80 or port 443.
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reported-by: default avatarMaciej Żenczykowski <maze@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6c1f0a1f
...@@ -9,12 +9,7 @@ struct net; ...@@ -9,12 +9,7 @@ struct net;
static inline u32 net_hash_mix(const struct net *net) static inline u32 net_hash_mix(const struct net *net)
{ {
#ifdef CONFIG_NET_NS #ifdef CONFIG_NET_NS
/* return (u32)(((unsigned long)net) >> ilog2(sizeof(*net)));
* shift this right to eliminate bits, that are
* always zeroed
*/
return (u32)(((unsigned long)net) >> L1_CACHE_SHIFT);
#else #else
return 0; return 0;
#endif #endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment