Commit 545d9d78 authored by Phil Elwell's avatar Phil Elwell Committed by Maxime Ripard

drm/v3d: Don't clear MMU control bits on exception

MMU exception conditions are reported in the V3D_MMU_CTRL register as
write-1-to-clear (W1C) bits. The MMU interrupt handling code clears any
exceptions, but does so by masking out any other bits and writing the
result back. There are some important control bits in that register,
including MMU_ENABLE, so a safer approach is to simply write back the
value just read unaltered.
Signed-off-by: default avatarPhil Elwell <phil@raspberrypi.org>
Signed-off-by: default avatarStefan Wahren <stefan.wahren@i2se.com>
Reviewed-by: default avatarNicolas Saenz Julienne <nsaenzjulienne@suse.de>
Signed-off-by: default avatarMaxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/1608755714-18233-4-git-send-email-stefan.wahren@i2se.com
parent 334dd38a
...@@ -178,10 +178,7 @@ v3d_hub_irq(int irq, void *arg) ...@@ -178,10 +178,7 @@ v3d_hub_irq(int irq, void *arg)
}; };
const char *client = "?"; const char *client = "?";
V3D_WRITE(V3D_MMU_CTL, V3D_WRITE(V3D_MMU_CTL, V3D_READ(V3D_MMU_CTL));
V3D_READ(V3D_MMU_CTL) & (V3D_MMU_CTL_CAP_EXCEEDED |
V3D_MMU_CTL_PT_INVALID |
V3D_MMU_CTL_WRITE_VIOLATION));
if (v3d->ver >= 41) { if (v3d->ver >= 41) {
axi_id = axi_id >> 5; axi_id = axi_id >> 5;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment