Commit 54acbaaa authored by Artem Bityutskiy's avatar Artem Bityutskiy

UBIFS: fix oops on error path in read_pnode

Thanks to coverity which spotted that UBIFS will oops if 'kmalloc()'
in 'read_pnode()' fails and we dereference a NULL 'pnode' pointer
when we 'goto out'.
Signed-off-by: default avatarArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
Cc: stable@kernel.org
parent 8b229c76
...@@ -1270,10 +1270,9 @@ static int read_pnode(struct ubifs_info *c, struct ubifs_nnode *parent, int iip) ...@@ -1270,10 +1270,9 @@ static int read_pnode(struct ubifs_info *c, struct ubifs_nnode *parent, int iip)
lnum = branch->lnum; lnum = branch->lnum;
offs = branch->offs; offs = branch->offs;
pnode = kzalloc(sizeof(struct ubifs_pnode), GFP_NOFS); pnode = kzalloc(sizeof(struct ubifs_pnode), GFP_NOFS);
if (!pnode) { if (!pnode)
err = -ENOMEM; return -ENOMEM;
goto out;
}
if (lnum == 0) { if (lnum == 0) {
/* /*
* This pnode was not written which just means that the LEB * This pnode was not written which just means that the LEB
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment