Commit 54be5509 authored by Alison Schofield's avatar Alison Schofield Committed by Steven Rostedt (Google)

tracepoint: Allow trace events in modules with TAINT_TEST

Commit 2852ca7f ("panic: Taint kernel if tests are run")
introduced a new taint type, TAINT_TEST, to signal that an
in-kernel test module has been loaded.

TAINT_TEST taint type defaults into a 'bad_taint' list for
kernel tracing and blocks the creation of trace events. This
causes a problem for CXL testing where loading the cxl_test
module makes all CXL modules out-of-tree, blocking any trace
events.

Trace events are in development for CXL at the moment and this
issue was found in test with v6.0-rc1.

Link: https://lkml.kernel.org/r/20220829171048.263065-1-alison.schofield@intel.com

Fixes: 2852ca7f ("panic: Taint kernel if tests are run")
Reported-by: default avatarIra Weiny <ira.weiny@intel.com>
Suggested-by: default avatarDan Williams <dan.j.williams@intel.com>
Tested-by: default avatarIra Weiny <ira.weiny@intel.com>
Reviewed-by: default avatarDavid Gow <davidgow@google.com>
Signed-off-by: default avatarAlison Schofield <alison.schofield@intel.com>
Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent f72c3a2d
...@@ -571,7 +571,8 @@ static void for_each_tracepoint_range( ...@@ -571,7 +571,8 @@ static void for_each_tracepoint_range(
bool trace_module_has_bad_taint(struct module *mod) bool trace_module_has_bad_taint(struct module *mod)
{ {
return mod->taints & ~((1 << TAINT_OOT_MODULE) | (1 << TAINT_CRAP) | return mod->taints & ~((1 << TAINT_OOT_MODULE) | (1 << TAINT_CRAP) |
(1 << TAINT_UNSIGNED_MODULE)); (1 << TAINT_UNSIGNED_MODULE) |
(1 << TAINT_TEST));
} }
static BLOCKING_NOTIFIER_HEAD(tracepoint_notify_list); static BLOCKING_NOTIFIER_HEAD(tracepoint_notify_list);
...@@ -647,7 +648,7 @@ static int tracepoint_module_coming(struct module *mod) ...@@ -647,7 +648,7 @@ static int tracepoint_module_coming(struct module *mod)
/* /*
* We skip modules that taint the kernel, especially those with different * We skip modules that taint the kernel, especially those with different
* module headers (for forced load), to make sure we don't cause a crash. * module headers (for forced load), to make sure we don't cause a crash.
* Staging, out-of-tree, and unsigned GPL modules are fine. * Staging, out-of-tree, unsigned GPL, and test modules are fine.
*/ */
if (trace_module_has_bad_taint(mod)) if (trace_module_has_bad_taint(mod))
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment