Commit 5502486a authored by Benson Leung's avatar Benson Leung Committed by Olof Johansson

platform/chrome: chromeos_laptop - Add a limit for deferred retries

Limit the number of times we allow deferred probing to attempt to add
i2c devices. This will help with some device flakiness at probe time.
For example, some touchpads and touchscreens may be in transition between
bootloader and operational mode and may appear at neither address briefly.

Adapters, however, have no limit as it depends on when the i2c adapter driver
module is loaded. The module may even be loaded manually by the user using
modprobe or insmod.

By default, set MAX_I2C_DEVICE_DEFERALS to 5.

Based on this patch from the chromeos-kernel :
https://chromium-review.googlesource.com/168130Signed-off-by: default avatarBenson Leung <bleung@chromium.org>
Signed-off-by: default avatarOlof Johansson <olof@lixom.net>
parent b90b3c4a
...@@ -37,6 +37,8 @@ ...@@ -37,6 +37,8 @@
#define ISL_ALS_I2C_ADDR 0x44 #define ISL_ALS_I2C_ADDR 0x44
#define TAOS_ALS_I2C_ADDR 0x29 #define TAOS_ALS_I2C_ADDR 0x29
#define MAX_I2C_DEVICE_DEFERRALS 5
static struct i2c_client *als; static struct i2c_client *als;
static struct i2c_client *tp; static struct i2c_client *tp;
static struct i2c_client *ts; static struct i2c_client *ts;
...@@ -58,9 +60,17 @@ enum i2c_adapter_type { ...@@ -58,9 +60,17 @@ enum i2c_adapter_type {
I2C_ADAPTER_DESIGNWARE_1, I2C_ADAPTER_DESIGNWARE_1,
}; };
enum i2c_peripheral_state {
UNPROBED = 0,
PROBED,
TIMEDOUT,
};
struct i2c_peripheral { struct i2c_peripheral {
int (*add)(enum i2c_adapter_type type); int (*add)(enum i2c_adapter_type type);
enum i2c_adapter_type type; enum i2c_adapter_type type;
enum i2c_peripheral_state state;
int tries;
}; };
#define MAX_I2C_PERIPHERALS 3 #define MAX_I2C_PERIPHERALS 3
...@@ -166,8 +176,8 @@ static struct i2c_client *__add_probed_i2c_device( ...@@ -166,8 +176,8 @@ static struct i2c_client *__add_probed_i2c_device(
/* add the i2c device */ /* add the i2c device */
client = i2c_new_probed_device(adapter, info, addrs, NULL); client = i2c_new_probed_device(adapter, info, addrs, NULL);
if (!client) if (!client)
pr_err("%s failed to register device %d-%02x\n", pr_notice("%s failed to register device %d-%02x\n",
__func__, bus, info->addr); __func__, bus, info->addr);
else else
pr_debug("%s added i2c device %d-%02x\n", pr_debug("%s added i2c device %d-%02x\n",
__func__, bus, info->addr); __func__, bus, info->addr);
...@@ -347,9 +357,36 @@ static int chromeos_laptop_probe(struct platform_device *pdev) ...@@ -347,9 +357,36 @@ static int chromeos_laptop_probe(struct platform_device *pdev)
if (i2c_dev->add == NULL) if (i2c_dev->add == NULL)
break; break;
/* Add the device. Set -EPROBE_DEFER on any failure */ if (i2c_dev->state == TIMEDOUT || i2c_dev->state == PROBED)
if (i2c_dev->add(i2c_dev->type)) continue;
/*
* Check that the i2c adapter is present.
* -EPROBE_DEFER if missing as the adapter may appear much
* later.
*/
if (find_i2c_adapter_num(i2c_dev->type) == -ENODEV) {
ret = -EPROBE_DEFER; ret = -EPROBE_DEFER;
continue;
}
/* Add the device. */
if (i2c_dev->add(i2c_dev->type) == -EAGAIN) {
/*
* Set -EPROBE_DEFER a limited num of times
* if device is not successfully added.
*/
if (++i2c_dev->tries < MAX_I2C_DEVICE_DEFERRALS) {
ret = -EPROBE_DEFER;
} else {
/* Ran out of tries. */
pr_notice("%s: Ran out of tries for device.\n",
__func__);
i2c_dev->state = TIMEDOUT;
}
} else {
i2c_dev->state = PROBED;
}
} }
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment