Commit 553dd569 authored by Sasha Levin's avatar Sasha Levin Committed by Jiri Slaby

net: llc: use correct size for sysctl timeout entries

commit 6b8d9117 upstream.

The timeout entries are sizeof(int) rather than sizeof(long), which
means that when they were getting read we'd also leak kernel memory
to userspace along with the timeout values.
Signed-off-by: default avatarSasha Levin <sasha.levin@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
parent b4482b53
...@@ -18,28 +18,28 @@ static struct ctl_table llc2_timeout_table[] = { ...@@ -18,28 +18,28 @@ static struct ctl_table llc2_timeout_table[] = {
{ {
.procname = "ack", .procname = "ack",
.data = &sysctl_llc2_ack_timeout, .data = &sysctl_llc2_ack_timeout,
.maxlen = sizeof(long), .maxlen = sizeof(sysctl_llc2_ack_timeout),
.mode = 0644, .mode = 0644,
.proc_handler = proc_dointvec_jiffies, .proc_handler = proc_dointvec_jiffies,
}, },
{ {
.procname = "busy", .procname = "busy",
.data = &sysctl_llc2_busy_timeout, .data = &sysctl_llc2_busy_timeout,
.maxlen = sizeof(long), .maxlen = sizeof(sysctl_llc2_busy_timeout),
.mode = 0644, .mode = 0644,
.proc_handler = proc_dointvec_jiffies, .proc_handler = proc_dointvec_jiffies,
}, },
{ {
.procname = "p", .procname = "p",
.data = &sysctl_llc2_p_timeout, .data = &sysctl_llc2_p_timeout,
.maxlen = sizeof(long), .maxlen = sizeof(sysctl_llc2_p_timeout),
.mode = 0644, .mode = 0644,
.proc_handler = proc_dointvec_jiffies, .proc_handler = proc_dointvec_jiffies,
}, },
{ {
.procname = "rej", .procname = "rej",
.data = &sysctl_llc2_rej_timeout, .data = &sysctl_llc2_rej_timeout,
.maxlen = sizeof(long), .maxlen = sizeof(sysctl_llc2_rej_timeout),
.mode = 0644, .mode = 0644,
.proc_handler = proc_dointvec_jiffies, .proc_handler = proc_dointvec_jiffies,
}, },
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment