Commit 56e2287b authored by Jesper Dangaard Brouer's avatar Jesper Dangaard Brouer Committed by Saeed Mahameed

mlx5: fix xdp data_meta setup in mlx5e_fill_xdp_buff

The helper function xdp_set_data_meta_invalid() must be called after
setting xdp->data as it depends on it.

The bug was introduced in the cited patch below, and cause the kernel
to crash when using BPF helper bpf_xdp_adjust_head() on mlx5 driver.

Fixes: 39d6443c ("mlx5, xsk: Migrate to new MEM_TYPE_XSK_BUFF_POOL")
Reported-by: default avatarDavid Ahern <dsahern@kernel.org>
Signed-off-by: default avatarJesper Dangaard Brouer <brouer@redhat.com>
Tested-by: default avatarDavid Ahern <dsahern@gmail.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
parent 971ae1ed
...@@ -1056,8 +1056,8 @@ static void mlx5e_fill_xdp_buff(struct mlx5e_rq *rq, void *va, u16 headroom, ...@@ -1056,8 +1056,8 @@ static void mlx5e_fill_xdp_buff(struct mlx5e_rq *rq, void *va, u16 headroom,
u32 len, struct xdp_buff *xdp) u32 len, struct xdp_buff *xdp)
{ {
xdp->data_hard_start = va; xdp->data_hard_start = va;
xdp_set_data_meta_invalid(xdp);
xdp->data = va + headroom; xdp->data = va + headroom;
xdp_set_data_meta_invalid(xdp);
xdp->data_end = xdp->data + len; xdp->data_end = xdp->data + len;
xdp->rxq = &rq->xdp_rxq; xdp->rxq = &rq->xdp_rxq;
xdp->frame_sz = rq->buff.frame0_sz; xdp->frame_sz = rq->buff.frame0_sz;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment