Commit 57128e98 authored by Jakub Kicinski's avatar Jakub Kicinski

tls: rx: fix the NoPad getsockopt

Maxim reports do_tls_getsockopt_no_pad() will
always return an error. Indeed looks like refactoring
gone wrong - remove err and use value.
Reported-by: default avatarMaxim Mikityanskiy <maximmi@nvidia.com>
Fixes: 88527790 ("tls: rx: add sockopt for enabling optimistic decrypt with TLS 1.3")
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent bb56cea9
...@@ -539,8 +539,7 @@ static int do_tls_getsockopt_no_pad(struct sock *sk, char __user *optval, ...@@ -539,8 +539,7 @@ static int do_tls_getsockopt_no_pad(struct sock *sk, char __user *optval,
int __user *optlen) int __user *optlen)
{ {
struct tls_context *ctx = tls_get_ctx(sk); struct tls_context *ctx = tls_get_ctx(sk);
unsigned int value; int value, len;
int err, len;
if (ctx->prot_info.version != TLS_1_3_VERSION) if (ctx->prot_info.version != TLS_1_3_VERSION)
return -EINVAL; return -EINVAL;
...@@ -551,12 +550,12 @@ static int do_tls_getsockopt_no_pad(struct sock *sk, char __user *optval, ...@@ -551,12 +550,12 @@ static int do_tls_getsockopt_no_pad(struct sock *sk, char __user *optval,
return -EINVAL; return -EINVAL;
lock_sock(sk); lock_sock(sk);
err = -EINVAL; value = -EINVAL;
if (ctx->rx_conf == TLS_SW || ctx->rx_conf == TLS_HW) if (ctx->rx_conf == TLS_SW || ctx->rx_conf == TLS_HW)
value = ctx->rx_no_pad; value = ctx->rx_no_pad;
release_sock(sk); release_sock(sk);
if (err) if (value < 0)
return err; return value;
if (put_user(sizeof(value), optlen)) if (put_user(sizeof(value), optlen))
return -EFAULT; return -EFAULT;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment