Commit 5724485b authored by Greta Zhang's avatar Greta Zhang Committed by Wim Van Sebroeck

watchdog: mtk_wdt: add wdt shutdown callback to disable wdt if enabled

Without .shutdown(), watchdog might reset the system during power off.
For example, if watchdog's timeout is set to 30s, then it is reset to
zero by mtk_wdt_ping(). During power off, no app will ping watchdog,
but watchdog is still running and may trigger reset.
Signed-off-by: default avatarGreta Zhang <greta.zhang@mediatek.com>
Signed-off-by: default avatarEddie Huang <eddie.huang@mediatek.com>
Acked-by: default avatarMatthias Brugger <matthias.bgg@gmail.com>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
parent 9fab0692
...@@ -210,6 +210,14 @@ static int mtk_wdt_probe(struct platform_device *pdev) ...@@ -210,6 +210,14 @@ static int mtk_wdt_probe(struct platform_device *pdev)
return 0; return 0;
} }
static void mtk_wdt_shutdown(struct platform_device *pdev)
{
struct mtk_wdt_dev *mtk_wdt = platform_get_drvdata(pdev);
if (watchdog_active(&mtk_wdt->wdt_dev))
mtk_wdt_stop(&mtk_wdt->wdt_dev);
}
static int mtk_wdt_remove(struct platform_device *pdev) static int mtk_wdt_remove(struct platform_device *pdev)
{ {
struct mtk_wdt_dev *mtk_wdt = platform_get_drvdata(pdev); struct mtk_wdt_dev *mtk_wdt = platform_get_drvdata(pdev);
...@@ -259,6 +267,7 @@ static const struct dev_pm_ops mtk_wdt_pm_ops = { ...@@ -259,6 +267,7 @@ static const struct dev_pm_ops mtk_wdt_pm_ops = {
static struct platform_driver mtk_wdt_driver = { static struct platform_driver mtk_wdt_driver = {
.probe = mtk_wdt_probe, .probe = mtk_wdt_probe,
.remove = mtk_wdt_remove, .remove = mtk_wdt_remove,
.shutdown = mtk_wdt_shutdown,
.driver = { .driver = {
.name = DRV_NAME, .name = DRV_NAME,
.pm = &mtk_wdt_pm_ops, .pm = &mtk_wdt_pm_ops,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment