Commit 57dca36e authored by Markus Elfring's avatar Markus Elfring Committed by Takashi Iwai

ALSA: seq: Deletion of unnecessary checks before the function call "snd_midi_event_free"

The snd_midi_event_free() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.
Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent adc2ae0b
...@@ -237,8 +237,7 @@ snd_seq_oss_midi_check_exit_port(int client, int port) ...@@ -237,8 +237,7 @@ snd_seq_oss_midi_check_exit_port(int client, int port)
spin_unlock_irqrestore(&register_lock, flags); spin_unlock_irqrestore(&register_lock, flags);
snd_use_lock_free(&mdev->use_lock); snd_use_lock_free(&mdev->use_lock);
snd_use_lock_sync(&mdev->use_lock); snd_use_lock_sync(&mdev->use_lock);
if (mdev->coder) snd_midi_event_free(mdev->coder);
snd_midi_event_free(mdev->coder);
kfree(mdev); kfree(mdev);
} }
spin_lock_irqsave(&register_lock, flags); spin_lock_irqsave(&register_lock, flags);
...@@ -265,8 +264,7 @@ snd_seq_oss_midi_clear_all(void) ...@@ -265,8 +264,7 @@ snd_seq_oss_midi_clear_all(void)
spin_lock_irqsave(&register_lock, flags); spin_lock_irqsave(&register_lock, flags);
for (i = 0; i < max_midi_devs; i++) { for (i = 0; i < max_midi_devs; i++) {
if ((mdev = midi_devs[i]) != NULL) { if ((mdev = midi_devs[i]) != NULL) {
if (mdev->coder) snd_midi_event_free(mdev->coder);
snd_midi_event_free(mdev->coder);
kfree(mdev); kfree(mdev);
midi_devs[i] = NULL; midi_devs[i] = NULL;
} }
......
...@@ -268,8 +268,7 @@ static void snd_seq_midisynth_delete(struct seq_midisynth *msynth) ...@@ -268,8 +268,7 @@ static void snd_seq_midisynth_delete(struct seq_midisynth *msynth)
snd_seq_event_port_detach(msynth->seq_client, msynth->seq_port); snd_seq_event_port_detach(msynth->seq_client, msynth->seq_port);
} }
if (msynth->parser) snd_midi_event_free(msynth->parser);
snd_midi_event_free(msynth->parser);
} }
/* register new midi synth port */ /* register new midi synth port */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment