Commit 57f1e875 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Greg Kroah-Hartman

auxdisplay: move cfag12864bfb's probe function to .devinit.text

A pointer to cfag12864bfb_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded.  Otherwise (if also having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.

An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: default avatarMiguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Avuton Olrich <avuton@gmail.com>
Cc: Antonino Daplas <adaplas@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent ea180ca4
...@@ -81,7 +81,7 @@ static struct fb_ops cfag12864bfb_ops = { ...@@ -81,7 +81,7 @@ static struct fb_ops cfag12864bfb_ops = {
.fb_mmap = cfag12864bfb_mmap, .fb_mmap = cfag12864bfb_mmap,
}; };
static int __init cfag12864bfb_probe(struct platform_device *device) static int __devinit cfag12864bfb_probe(struct platform_device *device)
{ {
int ret = -EINVAL; int ret = -EINVAL;
struct fb_info *info = framebuffer_alloc(0, &device->dev); struct fb_info *info = framebuffer_alloc(0, &device->dev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment