Commit 5813da15 authored by Dan Carpenter's avatar Dan Carpenter Committed by Guenter Roeck

hwmon: (max6621) Inverted if condition in max6621_read()

We intended to test for failure here but accidentally tested for
success.  It means that we don't set "*val" to true and it means that
if i2c_smbus_write_byte() does fail then we return success.

Fixes: e7895864b0d7 ("hwmon: (max6621) Add support for Maxim MAX6621 temperature sensor")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarVadim Pasternak <vadimp@mellanox.com>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent a3bdc5b5
...@@ -296,7 +296,7 @@ max6621_read(struct device *dev, enum hwmon_sensor_types type, u32 attr, ...@@ -296,7 +296,7 @@ max6621_read(struct device *dev, enum hwmon_sensor_types type, u32 attr,
if (regval) { if (regval) {
ret = i2c_smbus_write_byte(data->client, ret = i2c_smbus_write_byte(data->client,
MAX6621_CLEAR_ALERT_REG); MAX6621_CLEAR_ALERT_REG);
if (!ret) if (ret)
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment