Commit 58b15196 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Tzung-Bi Shih

platform/chrome: cros_ec_vbc: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230927081040.2198742-7-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarTzung-Bi Shih <tzungbi@kernel.org>
parent 6478e302
...@@ -121,14 +121,12 @@ static int cros_ec_vbc_probe(struct platform_device *pd) ...@@ -121,14 +121,12 @@ static int cros_ec_vbc_probe(struct platform_device *pd)
return ret; return ret;
} }
static int cros_ec_vbc_remove(struct platform_device *pd) static void cros_ec_vbc_remove(struct platform_device *pd)
{ {
struct cros_ec_dev *ec_dev = dev_get_drvdata(pd->dev.parent); struct cros_ec_dev *ec_dev = dev_get_drvdata(pd->dev.parent);
sysfs_remove_group(&ec_dev->class_dev.kobj, sysfs_remove_group(&ec_dev->class_dev.kobj,
&cros_ec_vbc_attr_group); &cros_ec_vbc_attr_group);
return 0;
} }
static struct platform_driver cros_ec_vbc_driver = { static struct platform_driver cros_ec_vbc_driver = {
...@@ -136,7 +134,7 @@ static struct platform_driver cros_ec_vbc_driver = { ...@@ -136,7 +134,7 @@ static struct platform_driver cros_ec_vbc_driver = {
.name = DRV_NAME, .name = DRV_NAME,
}, },
.probe = cros_ec_vbc_probe, .probe = cros_ec_vbc_probe,
.remove = cros_ec_vbc_remove, .remove_new = cros_ec_vbc_remove,
}; };
module_platform_driver(cros_ec_vbc_driver); module_platform_driver(cros_ec_vbc_driver);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment