Commit 5908cbe8 authored by Nathan Chancellor's avatar Nathan Chancellor Committed by Dmitry Baryshkov

usb: typec: nb7vpq904m: Only select DRM_AUX_BRIDGE with OF

CONFIG_DRM_AUX_BRIDGE depends on CONFIG_OF but that dependency is not
included when CONFIG_TYPEC_MUX_NB7VPQ904M selects it, resulting in a
Kconfig warning when CONFIG_OF is disabled:

  WARNING: unmet direct dependencies detected for DRM_AUX_BRIDGE
    Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n]
    Selected by [y]:
    - TYPEC_MUX_NB7VPQ904M [=y] && USB_SUPPORT [=y] && TYPEC [=y] && I2C [=y] && (DRM [=y] || DRM [=y]=n) && DRM_BRIDGE [=y]

Only select CONFIG_DRM_AUX_BRIDGE with both CONFIG_DRM_BRIDGE and
CONFIG_OF to clear up the warning.

Fixes: c5d296ba ("usb: typec: nb7vpq904m: switch to DRM_AUX_BRIDGE")
Signed-off-by: default avatarNathan Chancellor <nathan@kernel.org>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20231205-drm_aux_bridge-fixes-v1-1-d242a0ae9df4@kernel.org
parent 90d50b8d
...@@ -40,7 +40,7 @@ config TYPEC_MUX_NB7VPQ904M ...@@ -40,7 +40,7 @@ config TYPEC_MUX_NB7VPQ904M
tristate "On Semiconductor NB7VPQ904M Type-C redriver driver" tristate "On Semiconductor NB7VPQ904M Type-C redriver driver"
depends on I2C depends on I2C
depends on DRM || DRM=n depends on DRM || DRM=n
select DRM_AUX_BRIDGE if DRM_BRIDGE select DRM_AUX_BRIDGE if DRM_BRIDGE && OF
select REGMAP_I2C select REGMAP_I2C
help help
Say Y or M if your system has a On Semiconductor NB7VPQ904M Type-C Say Y or M if your system has a On Semiconductor NB7VPQ904M Type-C
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment