Commit 592a6318 authored by Anthony Koo's avatar Anthony Koo Committed by Alex Deucher

drm/amd/display: [FW Promotion] Release 0.0.56

More updates to the comments to better describe the function of
different cmds and parameters in the dmub interface.
Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarAnthony Koo <Anthony.Koo@amd.com>
Reviewed-by: default avatarAric Cyr <Aric.Cyr@amd.com>
Acked-by: default avatarSolomon Chiu <solomon.chiu@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 46a83eba
...@@ -47,10 +47,10 @@ ...@@ -47,10 +47,10 @@
/* Firmware versioning. */ /* Firmware versioning. */
#ifdef DMUB_EXPOSE_VERSION #ifdef DMUB_EXPOSE_VERSION
#define DMUB_FW_VERSION_GIT_HASH 0x920aff8b2 #define DMUB_FW_VERSION_GIT_HASH 0xc29b1734b
#define DMUB_FW_VERSION_MAJOR 0 #define DMUB_FW_VERSION_MAJOR 0
#define DMUB_FW_VERSION_MINOR 0 #define DMUB_FW_VERSION_MINOR 0
#define DMUB_FW_VERSION_REVISION 55 #define DMUB_FW_VERSION_REVISION 56
#define DMUB_FW_VERSION_TEST 0 #define DMUB_FW_VERSION_TEST 0
#define DMUB_FW_VERSION_VBIOS 0 #define DMUB_FW_VERSION_VBIOS 0
#define DMUB_FW_VERSION_HOTFIX 0 #define DMUB_FW_VERSION_HOTFIX 0
...@@ -120,14 +120,23 @@ ...@@ -120,14 +120,23 @@
/* Trace buffer offset for entry */ /* Trace buffer offset for entry */
#define TRACE_BUFFER_ENTRY_OFFSET 16 #define TRACE_BUFFER_ENTRY_OFFSET 16
/**
* Physical framebuffer address location, 64-bit.
*/
#ifndef PHYSICAL_ADDRESS_LOC #ifndef PHYSICAL_ADDRESS_LOC
#define PHYSICAL_ADDRESS_LOC union large_integer #define PHYSICAL_ADDRESS_LOC union large_integer
#endif #endif
/**
* OS/FW agnostic memcpy
*/
#ifndef dmub_memcpy #ifndef dmub_memcpy
#define dmub_memcpy(dest, source, bytes) memcpy((dest), (source), (bytes)) #define dmub_memcpy(dest, source, bytes) memcpy((dest), (source), (bytes))
#endif #endif
/**
* OS/FW agnostic memset
*/
#ifndef dmub_memset #ifndef dmub_memset
#define dmub_memset(dest, val, bytes) memset((dest), (val), (bytes)) #define dmub_memset(dest, val, bytes) memset((dest), (val), (bytes))
#endif #endif
...@@ -136,16 +145,22 @@ ...@@ -136,16 +145,22 @@
extern "C" { extern "C" {
#endif #endif
/**
* OS/FW agnostic udelay
*/
#ifndef dmub_udelay #ifndef dmub_udelay
#define dmub_udelay(microseconds) udelay(microseconds) #define dmub_udelay(microseconds) udelay(microseconds)
#endif #endif
/**
* union dmub_addr - DMUB physical/virtual 64-bit address.
*/
union dmub_addr { union dmub_addr {
struct { struct {
uint32_t low_part; uint32_t low_part; /**< Lower 32 bits */
uint32_t high_part; uint32_t high_part; /**< Upper 32 bits */
} u; } u; /*<< Low/high bit access */
uint64_t quad_part; uint64_t quad_part; /*<< 64 bit address */
}; };
/** /**
...@@ -187,11 +202,12 @@ struct dmub_feature_caps { ...@@ -187,11 +202,12 @@ struct dmub_feature_caps {
* Max PSR version supported by FW. * Max PSR version supported by FW.
*/ */
uint8_t psr; uint8_t psr;
#ifndef TRIM_FAMS
/** uint8_t fw_assisted_mclk_switch;
* Reserved. uint8_t reserved[6];
*/ #else
uint8_t reserved[7]; uint8_t reserved[7];
#endif
}; };
#if defined(__cplusplus) #if defined(__cplusplus)
...@@ -225,18 +241,20 @@ struct dmub_feature_caps { ...@@ -225,18 +241,20 @@ struct dmub_feature_caps {
* @dal_fw: 1 if the firmware is DAL * @dal_fw: 1 if the firmware is DAL
*/ */
struct dmub_fw_meta_info { struct dmub_fw_meta_info {
uint32_t magic_value; uint32_t magic_value; /**< magic value identifying DMUB firmware meta info */
uint32_t fw_region_size; uint32_t fw_region_size; /**< size of the firmware state region */
uint32_t trace_buffer_size; uint32_t trace_buffer_size; /**< size of the tracebuffer region */
uint32_t fw_version; uint32_t fw_version; /**< the firmware version information */
uint8_t dal_fw; uint8_t dal_fw; /**< 1 if the firmware is DAL */
uint8_t reserved[3]; uint8_t reserved[3]; /**< padding bits */
}; };
/* Ensure that the structure remains 64 bytes. */ /**
* union dmub_fw_meta - ensures that dmub_fw_meta_info remains 64 bytes
*/
union dmub_fw_meta { union dmub_fw_meta {
struct dmub_fw_meta_info info; struct dmub_fw_meta_info info; /**< metadata info */
uint8_t reserved[64]; uint8_t reserved[64]; /**< padding bits */
}; };
#pragma pack(pop) #pragma pack(pop)
...@@ -244,13 +262,19 @@ union dmub_fw_meta { ...@@ -244,13 +262,19 @@ union dmub_fw_meta {
//============================================================================== //==============================================================================
//< DMUB Trace Buffer>================================================================ //< DMUB Trace Buffer>================================================================
//============================================================================== //==============================================================================
/**
* dmub_trace_code_t - firmware trace code, 32-bits
*/
typedef uint32_t dmub_trace_code_t; typedef uint32_t dmub_trace_code_t;
/**
* struct dmcub_trace_buf_entry - Firmware trace entry
*/
struct dmcub_trace_buf_entry { struct dmcub_trace_buf_entry {
dmub_trace_code_t trace_code; dmub_trace_code_t trace_code; /**< trace code for the event */
uint32_t tick_count; uint32_t tick_count; /**< the tick count at time of trace */
uint32_t param0; uint32_t param0; /**< trace defined parameter 0 */
uint32_t param1; uint32_t param1; /**< trace defined parameter 1 */
}; };
//============================================================================== //==============================================================================
...@@ -265,42 +289,49 @@ struct dmcub_trace_buf_entry { ...@@ -265,42 +289,49 @@ struct dmcub_trace_buf_entry {
* SCRATCH15: FW Boot Options register * SCRATCH15: FW Boot Options register
*/ */
/* Register bit definition for SCRATCH0 */ /**
* union dmub_fw_boot_status - Status bit definitions for SCRATCH0.
*/
union dmub_fw_boot_status { union dmub_fw_boot_status {
struct { struct {
uint32_t dal_fw : 1; uint32_t dal_fw : 1; /**< 1 if DAL FW */
uint32_t mailbox_rdy : 1; uint32_t mailbox_rdy : 1; /**< 1 if mailbox ready */
uint32_t optimized_init_done : 1; uint32_t optimized_init_done : 1; /**< 1 if optimized init done */
uint32_t restore_required : 1; uint32_t restore_required : 1; /**< 1 if driver should call restore */
} bits; } bits; /**< status bits */
uint32_t all; uint32_t all; /**< 32-bit access to status bits */
}; };
/**
* enum dmub_fw_boot_status_bit - Enum bit definitions for SCRATCH0.
*/
enum dmub_fw_boot_status_bit { enum dmub_fw_boot_status_bit {
DMUB_FW_BOOT_STATUS_BIT_DAL_FIRMWARE = (1 << 0), DMUB_FW_BOOT_STATUS_BIT_DAL_FIRMWARE = (1 << 0), /**< 1 if DAL FW */
DMUB_FW_BOOT_STATUS_BIT_MAILBOX_READY = (1 << 1), DMUB_FW_BOOT_STATUS_BIT_MAILBOX_READY = (1 << 1), /**< 1 if mailbox ready */
DMUB_FW_BOOT_STATUS_BIT_OPTIMIZED_INIT_DONE = (1 << 2), DMUB_FW_BOOT_STATUS_BIT_OPTIMIZED_INIT_DONE = (1 << 2), /**< 1 if init done */
DMUB_FW_BOOT_STATUS_BIT_RESTORE_REQUIRED = (1 << 3), DMUB_FW_BOOT_STATUS_BIT_RESTORE_REQUIRED = (1 << 3), /**< 1 if driver should call restore */
}; };
/* Register bit definition for SCRATCH15 */ /**
* union dmub_fw_boot_options - Boot option definitions for SCRATCH15
*/
union dmub_fw_boot_options { union dmub_fw_boot_options {
struct { struct {
uint32_t pemu_env : 1; uint32_t pemu_env : 1; /**< 1 if PEMU */
uint32_t fpga_env : 1; uint32_t fpga_env : 1; /**< 1 if FPGA */
uint32_t optimized_init : 1; uint32_t optimized_init : 1; /**< 1 if optimized init */
uint32_t skip_phy_access : 1; uint32_t skip_phy_access : 1; /**< 1 if PHY access should be skipped */
uint32_t disable_clk_gate: 1; uint32_t disable_clk_gate: 1; /**< 1 if clock gating should be disabled */
uint32_t skip_phy_init_panel_sequence: 1; uint32_t skip_phy_init_panel_sequence: 1; /**< 1 to skip panel init seq */
uint32_t reserved : 26; uint32_t reserved : 26; /**< reserved */
} bits; } bits; /**< boot bits */
uint32_t all; uint32_t all; /**< 32-bit access to bits */
}; };
enum dmub_fw_boot_options_bit { enum dmub_fw_boot_options_bit {
DMUB_FW_BOOT_OPTION_BIT_PEMU_ENV = (1 << 0), DMUB_FW_BOOT_OPTION_BIT_PEMU_ENV = (1 << 0), /**< 1 if PEMU */
DMUB_FW_BOOT_OPTION_BIT_FPGA_ENV = (1 << 1), DMUB_FW_BOOT_OPTION_BIT_FPGA_ENV = (1 << 1), /**< 1 if FPGA */
DMUB_FW_BOOT_OPTION_BIT_OPTIMIZED_INIT_DONE = (1 << 2), DMUB_FW_BOOT_OPTION_BIT_OPTIMIZED_INIT_DONE = (1 << 2), /**< 1 if optimized init done */
}; };
//============================================================================== //==============================================================================
...@@ -310,14 +341,27 @@ enum dmub_fw_boot_options_bit { ...@@ -310,14 +341,27 @@ enum dmub_fw_boot_options_bit {
//============================================================================== //==============================================================================
/* /*
* enum dmub_cmd_vbios_type - VBIOS commands.
*
* Command IDs should be treated as stable ABI. * Command IDs should be treated as stable ABI.
* Do not reuse or modify IDs. * Do not reuse or modify IDs.
*/ */
enum dmub_cmd_vbios_type { enum dmub_cmd_vbios_type {
/**
* Configures the DIG encoder.
*/
DMUB_CMD__VBIOS_DIGX_ENCODER_CONTROL = 0, DMUB_CMD__VBIOS_DIGX_ENCODER_CONTROL = 0,
/**
* Controls the PHY.
*/
DMUB_CMD__VBIOS_DIG1_TRANSMITTER_CONTROL = 1, DMUB_CMD__VBIOS_DIG1_TRANSMITTER_CONTROL = 1,
/**
* Sets the pixel clock/symbol clock.
*/
DMUB_CMD__VBIOS_SET_PIXEL_CLOCK = 2, DMUB_CMD__VBIOS_SET_PIXEL_CLOCK = 2,
/**
* Enables or disables power gating.
*/
DMUB_CMD__VBIOS_ENABLE_DISP_POWER_GATING = 3, DMUB_CMD__VBIOS_ENABLE_DISP_POWER_GATING = 3,
DMUB_CMD__VBIOS_LVTMA_CONTROL = 15, DMUB_CMD__VBIOS_LVTMA_CONTROL = 15,
}; };
...@@ -346,28 +390,43 @@ enum dmub_cmd_vbios_type { ...@@ -346,28 +390,43 @@ enum dmub_cmd_vbios_type {
* Command responses. * Command responses.
*/ */
/**
* Return response for DMUB_GPINT__STOP_FW command.
*/
#define DMUB_GPINT__STOP_FW_RESPONSE 0xDEADDEAD #define DMUB_GPINT__STOP_FW_RESPONSE 0xDEADDEAD
/** /**
* The register format for sending a command via the GPINT. * union dmub_gpint_data_register - Format for sending a command via the GPINT.
*/ */
union dmub_gpint_data_register { union dmub_gpint_data_register {
struct { struct {
uint32_t param : 16; uint32_t param : 16; /**< 16-bit parameter */
uint32_t command_code : 12; uint32_t command_code : 12; /**< GPINT command */
uint32_t status : 4; uint32_t status : 4; /**< Command status bit */
} bits; } bits; /**< GPINT bit access */
uint32_t all; uint32_t all; /**< GPINT 32-bit access */
}; };
/* /*
* enum dmub_gpint_command - GPINT command to DMCUB FW
*
* Command IDs should be treated as stable ABI. * Command IDs should be treated as stable ABI.
* Do not reuse or modify IDs. * Do not reuse or modify IDs.
*/ */
enum dmub_gpint_command { enum dmub_gpint_command {
/**
* Invalid command, ignored.
*/
DMUB_GPINT__INVALID_COMMAND = 0, DMUB_GPINT__INVALID_COMMAND = 0,
/**
* DESC: Queries the firmware version.
* RETURN: Firmware version.
*/
DMUB_GPINT__GET_FW_VERSION = 1, DMUB_GPINT__GET_FW_VERSION = 1,
/**
* DESC: Halts the firmware.
* RETURN: DMUB_GPINT__STOP_FW_RESPONSE (0xDEADDEAD) when halted
*/
DMUB_GPINT__STOP_FW = 2, DMUB_GPINT__STOP_FW = 2,
/** /**
* DESC: Get PSR state from FW. * DESC: Get PSR state from FW.
...@@ -394,22 +453,56 @@ enum dmub_gpint_command { ...@@ -394,22 +453,56 @@ enum dmub_gpint_command {
//< DMUB_CMD>=================================================================== //< DMUB_CMD>===================================================================
//============================================================================== //==============================================================================
/**
* Size in bytes of each DMUB command.
*/
#define DMUB_RB_CMD_SIZE 64 #define DMUB_RB_CMD_SIZE 64
/**
* Maximum number of items in the DMUB ringbuffer.
*/
#define DMUB_RB_MAX_ENTRY 128 #define DMUB_RB_MAX_ENTRY 128
/**
* Ringbuffer size in bytes.
*/
#define DMUB_RB_SIZE (DMUB_RB_CMD_SIZE * DMUB_RB_MAX_ENTRY) #define DMUB_RB_SIZE (DMUB_RB_CMD_SIZE * DMUB_RB_MAX_ENTRY)
/**
* REG_SET mask for reg offload.
*/
#define REG_SET_MASK 0xFFFF #define REG_SET_MASK 0xFFFF
/* /*
* enum dmub_cmd_type - DMUB inbox command.
*
* Command IDs should be treated as stable ABI. * Command IDs should be treated as stable ABI.
* Do not reuse or modify IDs. * Do not reuse or modify IDs.
*/ */
enum dmub_cmd_type { enum dmub_cmd_type {
/**
* Invalid command.
*/
DMUB_CMD__NULL = 0, DMUB_CMD__NULL = 0,
/**
* Read modify write register sequence offload.
*/
DMUB_CMD__REG_SEQ_READ_MODIFY_WRITE = 1, DMUB_CMD__REG_SEQ_READ_MODIFY_WRITE = 1,
/**
* Field update register sequence offload.
*/
DMUB_CMD__REG_SEQ_FIELD_UPDATE_SEQ = 2, DMUB_CMD__REG_SEQ_FIELD_UPDATE_SEQ = 2,
/**
* Burst write sequence offload.
*/
DMUB_CMD__REG_SEQ_BURST_WRITE = 3, DMUB_CMD__REG_SEQ_BURST_WRITE = 3,
/**
* Reg wait sequence offload.
*/
DMUB_CMD__REG_REG_WAIT = 4, DMUB_CMD__REG_REG_WAIT = 4,
/**
* Workaround to avoid HUBP underflow during NV12 playback.
*/
DMUB_CMD__PLAT_54186_WA = 5, DMUB_CMD__PLAT_54186_WA = 5,
/** /**
* Command type used to query FW feature caps. * Command type used to query FW feature caps.
...@@ -419,6 +512,9 @@ enum dmub_cmd_type { ...@@ -419,6 +512,9 @@ enum dmub_cmd_type {
* Command type used for all PSR commands. * Command type used for all PSR commands.
*/ */
DMUB_CMD__PSR = 64, DMUB_CMD__PSR = 64,
/**
* Command type used for all MALL commands.
*/
DMUB_CMD__MALL = 65, DMUB_CMD__MALL = 65,
/** /**
* Command type used for all ABM commands. * Command type used for all ABM commands.
...@@ -436,10 +532,23 @@ enum dmub_cmd_type { ...@@ -436,10 +532,23 @@ enum dmub_cmd_type {
* Command type used for OUTBOX1 notification enable * Command type used for OUTBOX1 notification enable
*/ */
DMUB_CMD__OUTBOX1_ENABLE = 71, DMUB_CMD__OUTBOX1_ENABLE = 71,
#ifndef TRIM_FAMS
DMUB_CMD__FW_ASSISTED_MCLK_SWITCH = 76,
#endif
/**
* Command type used for all VBIOS interface commands.
*/
DMUB_CMD__VBIOS = 128, DMUB_CMD__VBIOS = 128,
}; };
/**
* enum dmub_out_cmd_type - DMUB outbox commands.
*/
enum dmub_out_cmd_type { enum dmub_out_cmd_type {
/**
* Invalid outbox command, ignored.
*/
DMUB_OUT_CMD__NULL = 0, DMUB_OUT_CMD__NULL = 0,
/** /**
* Command type used for DP AUX Reply data notification * Command type used for DP AUX Reply data notification
...@@ -453,17 +562,20 @@ enum dmub_out_cmd_type { ...@@ -453,17 +562,20 @@ enum dmub_out_cmd_type {
#pragma pack(push, 1) #pragma pack(push, 1)
/**
* struct dmub_cmd_header - Common command header fields.
*/
struct dmub_cmd_header { struct dmub_cmd_header {
unsigned int type : 8; unsigned int type : 8; /**< command type */
unsigned int sub_type : 8; unsigned int sub_type : 8; /**< command sub type */
unsigned int ret_status : 1; unsigned int ret_status : 1; /**< 1 if returned data, 0 otherwise */
unsigned int reserved0 : 7; unsigned int reserved0 : 7; /**< reserved bits */
unsigned int payload_bytes : 6; /* up to 60 bytes */ unsigned int payload_bytes : 6; /* payload excluding header - up to 60 bytes */
unsigned int reserved1 : 2; unsigned int reserved1 : 2; /**< reserved bits */
}; };
/* /*
* Read modify write * struct dmub_cmd_read_modify_write_sequence - Read modify write
* *
* 60 payload bytes can hold up to 5 sets of read modify writes, * 60 payload bytes can hold up to 5 sets of read modify writes,
* each take 3 dwords. * each take 3 dwords.
...@@ -474,14 +586,24 @@ struct dmub_cmd_header { ...@@ -474,14 +586,24 @@ struct dmub_cmd_header {
* command parser will skip the read and we can use modify_mask = 0xffff'ffff as reg write * command parser will skip the read and we can use modify_mask = 0xffff'ffff as reg write
*/ */
struct dmub_cmd_read_modify_write_sequence { struct dmub_cmd_read_modify_write_sequence {
uint32_t addr; uint32_t addr; /**< register address */
uint32_t modify_mask; uint32_t modify_mask; /**< modify mask */
uint32_t modify_value; uint32_t modify_value; /**< modify value */
}; };
/**
* Maximum number of ops in read modify write sequence.
*/
#define DMUB_READ_MODIFY_WRITE_SEQ__MAX 5 #define DMUB_READ_MODIFY_WRITE_SEQ__MAX 5
/**
* struct dmub_cmd_read_modify_write_sequence - Read modify write command.
*/
struct dmub_rb_cmd_read_modify_write { struct dmub_rb_cmd_read_modify_write {
struct dmub_cmd_header header; // type = DMUB_CMD__REG_SEQ_READ_MODIFY_WRITE struct dmub_cmd_header header; /**< command header */
/**
* Read modify write sequence.
*/
struct dmub_cmd_read_modify_write_sequence seq[DMUB_READ_MODIFY_WRITE_SEQ__MAX]; struct dmub_cmd_read_modify_write_sequence seq[DMUB_READ_MODIFY_WRITE_SEQ__MAX];
}; };
...@@ -499,19 +621,35 @@ struct dmub_rb_cmd_read_modify_write { ...@@ -499,19 +621,35 @@ struct dmub_rb_cmd_read_modify_write {
*/ */
struct dmub_cmd_reg_field_update_sequence { struct dmub_cmd_reg_field_update_sequence {
uint32_t modify_mask; // 0xffff'ffff to skip initial read uint32_t modify_mask; /**< 0xffff'ffff to skip initial read */
uint32_t modify_value; uint32_t modify_value; /**< value to update with */
}; };
/**
* Maximum number of ops in field update sequence.
*/
#define DMUB_REG_FIELD_UPDATE_SEQ__MAX 7 #define DMUB_REG_FIELD_UPDATE_SEQ__MAX 7
/**
* struct dmub_rb_cmd_reg_field_update_sequence - Field update command.
*/
struct dmub_rb_cmd_reg_field_update_sequence { struct dmub_rb_cmd_reg_field_update_sequence {
struct dmub_cmd_header header; struct dmub_cmd_header header; /**< command header */
uint32_t addr; uint32_t addr; /**< register address */
/**
* Field update sequence.
*/
struct dmub_cmd_reg_field_update_sequence seq[DMUB_REG_FIELD_UPDATE_SEQ__MAX]; struct dmub_cmd_reg_field_update_sequence seq[DMUB_REG_FIELD_UPDATE_SEQ__MAX];
}; };
/**
* Maximum number of burst write values.
*/
#define DMUB_BURST_WRITE_VALUES__MAX 14
/* /*
* Burst write * struct dmub_rb_cmd_burst_write - Burst write
* *
* support use case such as writing out LUTs. * support use case such as writing out LUTs.
* *
...@@ -519,96 +657,141 @@ struct dmub_rb_cmd_reg_field_update_sequence { ...@@ -519,96 +657,141 @@ struct dmub_rb_cmd_reg_field_update_sequence {
* *
* number of payload = header.payload_bytes / sizeof(struct read_modify_write_sequence) * number of payload = header.payload_bytes / sizeof(struct read_modify_write_sequence)
*/ */
#define DMUB_BURST_WRITE_VALUES__MAX 14
struct dmub_rb_cmd_burst_write { struct dmub_rb_cmd_burst_write {
struct dmub_cmd_header header; // type = DMUB_CMD__REG_SEQ_BURST_WRITE struct dmub_cmd_header header; /**< command header */
uint32_t addr; uint32_t addr; /**< register start address */
/**
* Burst write register values.
*/
uint32_t write_values[DMUB_BURST_WRITE_VALUES__MAX]; uint32_t write_values[DMUB_BURST_WRITE_VALUES__MAX];
}; };
/**
* struct dmub_rb_cmd_common - Common command header
*/
struct dmub_rb_cmd_common { struct dmub_rb_cmd_common {
struct dmub_cmd_header header; struct dmub_cmd_header header; /**< command header */
/**
* Padding to RB_CMD_SIZE
*/
uint8_t cmd_buffer[DMUB_RB_CMD_SIZE - sizeof(struct dmub_cmd_header)]; uint8_t cmd_buffer[DMUB_RB_CMD_SIZE - sizeof(struct dmub_cmd_header)];
}; };
/**
* struct dmub_cmd_reg_wait_data - Register wait data
*/
struct dmub_cmd_reg_wait_data { struct dmub_cmd_reg_wait_data {
uint32_t addr; uint32_t addr; /**< Register address */
uint32_t mask; uint32_t mask; /**< Mask for register bits */
uint32_t condition_field_value; uint32_t condition_field_value; /**< Value to wait for */
uint32_t time_out_us; uint32_t time_out_us; /**< Time out for reg wait in microseconds */
}; };
/**
* struct dmub_rb_cmd_reg_wait - Register wait command
*/
struct dmub_rb_cmd_reg_wait { struct dmub_rb_cmd_reg_wait {
struct dmub_cmd_header header; struct dmub_cmd_header header; /**< Command header */
struct dmub_cmd_reg_wait_data reg_wait; struct dmub_cmd_reg_wait_data reg_wait; /**< Register wait data */
}; };
/**
* struct dmub_cmd_PLAT_54186_wa - Underflow workaround
*
* Reprograms surface parameters to avoid underflow.
*/
struct dmub_cmd_PLAT_54186_wa { struct dmub_cmd_PLAT_54186_wa {
uint32_t DCSURF_SURFACE_CONTROL; uint32_t DCSURF_SURFACE_CONTROL; /**< reg value */
uint32_t DCSURF_PRIMARY_SURFACE_ADDRESS_HIGH; uint32_t DCSURF_PRIMARY_SURFACE_ADDRESS_HIGH; /**< reg value */
uint32_t DCSURF_PRIMARY_SURFACE_ADDRESS; uint32_t DCSURF_PRIMARY_SURFACE_ADDRESS; /**< reg value */
uint32_t DCSURF_PRIMARY_SURFACE_ADDRESS_HIGH_C; uint32_t DCSURF_PRIMARY_SURFACE_ADDRESS_HIGH_C; /**< reg value */
uint32_t DCSURF_PRIMARY_SURFACE_ADDRESS_C; uint32_t DCSURF_PRIMARY_SURFACE_ADDRESS_C; /**< reg value */
struct { struct {
uint8_t hubp_inst : 4; uint8_t hubp_inst : 4; /**< HUBP instance */
uint8_t tmz_surface : 1; uint8_t tmz_surface : 1; /**< TMZ enable or disable */
uint8_t immediate :1; uint8_t immediate :1; /**< Immediate flip */
uint8_t vmid : 4; uint8_t vmid : 4; /**< VMID */
uint8_t grph_stereo : 1; uint8_t grph_stereo : 1; /**< 1 if stereo */
uint32_t reserved : 21; uint32_t reserved : 21; /**< Reserved */
} flip_params; } flip_params; /**< Pageflip parameters */
uint32_t reserved[9]; uint32_t reserved[9]; /**< Reserved bits */
}; };
/**
* struct dmub_rb_cmd_PLAT_54186_wa - Underflow workaround command
*/
struct dmub_rb_cmd_PLAT_54186_wa { struct dmub_rb_cmd_PLAT_54186_wa {
struct dmub_cmd_header header; struct dmub_cmd_header header; /**< Command header */
struct dmub_cmd_PLAT_54186_wa flip; struct dmub_cmd_PLAT_54186_wa flip; /**< Flip data */
}; };
/**
* struct dmub_rb_cmd_mall - MALL command data.
*/
struct dmub_rb_cmd_mall { struct dmub_rb_cmd_mall {
struct dmub_cmd_header header; struct dmub_cmd_header header; /**< Common command header */
union dmub_addr cursor_copy_src; union dmub_addr cursor_copy_src; /**< Cursor copy address */
union dmub_addr cursor_copy_dst; union dmub_addr cursor_copy_dst; /**< Cursor copy destination */
uint32_t tmr_delay; uint32_t tmr_delay; /**< Timer delay */
uint32_t tmr_scale; uint32_t tmr_scale; /**< Timer scale */
uint16_t cursor_width; uint16_t cursor_width; /**< Cursor width in pixels */
uint16_t cursor_pitch; uint16_t cursor_pitch; /**< Cursor pitch in pixels */
uint16_t cursor_height; uint16_t cursor_height; /**< Cursor height in pixels */
uint8_t cursor_bpp; uint8_t cursor_bpp; /**< Cursor bits per pixel */
uint8_t debug_bits; uint8_t debug_bits; /**< Debug bits */
uint8_t reserved1; uint8_t reserved1; /**< Reserved bits */
uint8_t reserved2; uint8_t reserved2; /**< Reserved bits */
}; };
/**
* struct dmub_cmd_digx_encoder_control_data - Encoder control data.
*/
struct dmub_cmd_digx_encoder_control_data { struct dmub_cmd_digx_encoder_control_data {
union dig_encoder_control_parameters_v1_5 dig; union dig_encoder_control_parameters_v1_5 dig; /**< payload */
}; };
/**
* struct dmub_rb_cmd_digx_encoder_control - Encoder control command.
*/
struct dmub_rb_cmd_digx_encoder_control { struct dmub_rb_cmd_digx_encoder_control {
struct dmub_cmd_header header; struct dmub_cmd_header header; /**< header */
struct dmub_cmd_digx_encoder_control_data encoder_control; struct dmub_cmd_digx_encoder_control_data encoder_control; /**< payload */
}; };
/**
* struct dmub_cmd_set_pixel_clock_data - Set pixel clock data.
*/
struct dmub_cmd_set_pixel_clock_data { struct dmub_cmd_set_pixel_clock_data {
struct set_pixel_clock_parameter_v1_7 clk; struct set_pixel_clock_parameter_v1_7 clk; /**< payload */
}; };
/**
* struct dmub_cmd_set_pixel_clock_data - Set pixel clock command.
*/
struct dmub_rb_cmd_set_pixel_clock { struct dmub_rb_cmd_set_pixel_clock {
struct dmub_cmd_header header; struct dmub_cmd_header header; /**< header */
struct dmub_cmd_set_pixel_clock_data pixel_clock; struct dmub_cmd_set_pixel_clock_data pixel_clock; /**< payload */
}; };
/**
* struct dmub_cmd_enable_disp_power_gating_data - Display power gating.
*/
struct dmub_cmd_enable_disp_power_gating_data { struct dmub_cmd_enable_disp_power_gating_data {
struct enable_disp_power_gating_parameters_v2_1 pwr; struct enable_disp_power_gating_parameters_v2_1 pwr; /**< payload */
}; };
/**
* struct dmub_rb_cmd_enable_disp_power_gating - Display power command.
*/
struct dmub_rb_cmd_enable_disp_power_gating { struct dmub_rb_cmd_enable_disp_power_gating {
struct dmub_cmd_header header; struct dmub_cmd_header header; /**< header */
struct dmub_cmd_enable_disp_power_gating_data power_gating; struct dmub_cmd_enable_disp_power_gating_data power_gating; /**< payload */
}; };
/**
* struct dmub_dig_transmitter_control_data_v1_7 - Transmitter control.
*/
struct dmub_dig_transmitter_control_data_v1_7 { struct dmub_dig_transmitter_control_data_v1_7 {
uint8_t phyid; /**< 0=UNIPHYA, 1=UNIPHYB, 2=UNIPHYC, 3=UNIPHYD, 4=UNIPHYE, 5=UNIPHYF */ uint8_t phyid; /**< 0=UNIPHYA, 1=UNIPHYB, 2=UNIPHYC, 3=UNIPHYD, 4=UNIPHYE, 5=UNIPHYF */
uint8_t action; /**< Defined as ATOM_TRANSMITER_ACTION_xxx */ uint8_t action; /**< Defined as ATOM_TRANSMITER_ACTION_xxx */
...@@ -629,19 +812,28 @@ struct dmub_dig_transmitter_control_data_v1_7 { ...@@ -629,19 +812,28 @@ struct dmub_dig_transmitter_control_data_v1_7 {
uint32_t reserved3[11]; /**< For future use */ uint32_t reserved3[11]; /**< For future use */
}; };
/**
* union dmub_cmd_dig1_transmitter_control_data - Transmitter control data.
*/
union dmub_cmd_dig1_transmitter_control_data { union dmub_cmd_dig1_transmitter_control_data {
struct dig_transmitter_control_parameters_v1_6 dig; struct dig_transmitter_control_parameters_v1_6 dig; /**< payload */
struct dmub_dig_transmitter_control_data_v1_7 dig_v1_7; struct dmub_dig_transmitter_control_data_v1_7 dig_v1_7; /**< payload 1.7 */
}; };
/**
* struct dmub_rb_cmd_dig1_transmitter_control - Transmitter control command.
*/
struct dmub_rb_cmd_dig1_transmitter_control { struct dmub_rb_cmd_dig1_transmitter_control {
struct dmub_cmd_header header; struct dmub_cmd_header header; /**< header */
union dmub_cmd_dig1_transmitter_control_data transmitter_control; union dmub_cmd_dig1_transmitter_control_data transmitter_control; /**< payload */
}; };
/**
* struct dmub_rb_cmd_dpphy_init - DPPHY init.
*/
struct dmub_rb_cmd_dpphy_init { struct dmub_rb_cmd_dpphy_init {
struct dmub_cmd_header header; struct dmub_cmd_header header; /**< header */
uint8_t reserved[60]; uint8_t reserved[60]; /**< reserved bits */
}; };
/** /**
...@@ -923,6 +1115,13 @@ enum dmub_cmd_psr_type { ...@@ -923,6 +1115,13 @@ enum dmub_cmd_psr_type {
DMUB_CMD__PSR_FORCE_STATIC = 5, DMUB_CMD__PSR_FORCE_STATIC = 5,
}; };
#ifndef TRIM_FAMS
enum dmub_cmd_fams_type {
DMUB_CMD__FAMS_SETUP_FW_CTRL = 0,
DMUB_CMD__FAMS_DRR_UPDATE = 1,
};
#endif
/** /**
* PSR versions. * PSR versions.
*/ */
...@@ -937,13 +1136,29 @@ enum psr_version { ...@@ -937,13 +1136,29 @@ enum psr_version {
PSR_VERSION_UNSUPPORTED = 0xFFFFFFFF, PSR_VERSION_UNSUPPORTED = 0xFFFFFFFF,
}; };
/**
* enum dmub_cmd_mall_type - MALL commands
*/
enum dmub_cmd_mall_type { enum dmub_cmd_mall_type {
/**
* Allows display refresh from MALL.
*/
DMUB_CMD__MALL_ACTION_ALLOW = 0, DMUB_CMD__MALL_ACTION_ALLOW = 0,
/**
* Disallows display refresh from MALL.
*/
DMUB_CMD__MALL_ACTION_DISALLOW = 1, DMUB_CMD__MALL_ACTION_DISALLOW = 1,
/**
* Cursor copy for MALL.
*/
DMUB_CMD__MALL_ACTION_COPY_CURSOR = 2, DMUB_CMD__MALL_ACTION_COPY_CURSOR = 2,
/**
* Controls DF requests.
*/
DMUB_CMD__MALL_ACTION_NO_DF_REQ = 3, DMUB_CMD__MALL_ACTION_NO_DF_REQ = 3,
}; };
/** /**
* Data passed from driver to FW in a DMUB_CMD__PSR_COPY_SETTINGS command. * Data passed from driver to FW in a DMUB_CMD__PSR_COPY_SETTINGS command.
*/ */
...@@ -1561,6 +1776,39 @@ struct dmub_rb_cmd_query_feature_caps { ...@@ -1561,6 +1776,39 @@ struct dmub_rb_cmd_query_feature_caps {
struct dmub_cmd_query_feature_caps_data query_feature_caps_data; struct dmub_cmd_query_feature_caps_data query_feature_caps_data;
}; };
struct dmub_optc_state {
uint32_t v_total_max;
uint32_t v_total_min;
uint32_t v_total_mid;
uint32_t v_total_mid_frame_num;
uint32_t tg_inst;
uint32_t enable_manual_trigger;
uint32_t clear_force_vsync;
};
struct dmub_rb_cmd_drr_update {
struct dmub_cmd_header header;
struct dmub_optc_state dmub_optc_state_req;
};
#ifndef TRIM_FAMS
struct dmub_cmd_fw_assisted_mclk_switch_pipe_data {
uint32_t pix_clk_100hz;
uint32_t min_refresh_in_uhz;
uint32_t max_ramp_step;
};
struct dmub_cmd_fw_assisted_mclk_switch_config {
uint32_t fams_enabled;
struct dmub_cmd_fw_assisted_mclk_switch_pipe_data pipe_data[DMUB_MAX_STREAMS];
};
struct dmub_rb_cmd_fw_assisted_mclk_switch {
struct dmub_cmd_header header;
struct dmub_cmd_fw_assisted_mclk_switch_config config_data;
};
#endif
/** /**
* Data passed from driver to FW in a DMUB_CMD__VBIOS_LVTMA_CONTROL command. * Data passed from driver to FW in a DMUB_CMD__VBIOS_LVTMA_CONTROL command.
*/ */
...@@ -1585,17 +1833,50 @@ struct dmub_rb_cmd_lvtma_control { ...@@ -1585,17 +1833,50 @@ struct dmub_rb_cmd_lvtma_control {
struct dmub_cmd_lvtma_control_data data; struct dmub_cmd_lvtma_control_data data;
}; };
/**
* union dmub_rb_cmd - DMUB inbox command.
*/
union dmub_rb_cmd { union dmub_rb_cmd {
struct dmub_rb_cmd_lock_hw lock_hw; struct dmub_rb_cmd_lock_hw lock_hw;
/**
* Elements shared with all commands.
*/
struct dmub_rb_cmd_common cmd_common;
/**
* Definition of a DMUB_CMD__REG_SEQ_READ_MODIFY_WRITE command.
*/
struct dmub_rb_cmd_read_modify_write read_modify_write; struct dmub_rb_cmd_read_modify_write read_modify_write;
/**
* Definition of a DMUB_CMD__REG_SEQ_FIELD_UPDATE_SEQ command.
*/
struct dmub_rb_cmd_reg_field_update_sequence reg_field_update_seq; struct dmub_rb_cmd_reg_field_update_sequence reg_field_update_seq;
/**
* Definition of a DMUB_CMD__REG_SEQ_BURST_WRITE command.
*/
struct dmub_rb_cmd_burst_write burst_write; struct dmub_rb_cmd_burst_write burst_write;
/**
* Definition of a DMUB_CMD__REG_REG_WAIT command.
*/
struct dmub_rb_cmd_reg_wait reg_wait; struct dmub_rb_cmd_reg_wait reg_wait;
struct dmub_rb_cmd_common cmd_common; /**
* Definition of a DMUB_CMD__VBIOS_DIGX_ENCODER_CONTROL command.
*/
struct dmub_rb_cmd_digx_encoder_control digx_encoder_control; struct dmub_rb_cmd_digx_encoder_control digx_encoder_control;
/**
* Definition of a DMUB_CMD__VBIOS_SET_PIXEL_CLOCK command.
*/
struct dmub_rb_cmd_set_pixel_clock set_pixel_clock; struct dmub_rb_cmd_set_pixel_clock set_pixel_clock;
/**
* Definition of a DMUB_CMD__VBIOS_ENABLE_DISP_POWER_GATING command.
*/
struct dmub_rb_cmd_enable_disp_power_gating enable_disp_power_gating; struct dmub_rb_cmd_enable_disp_power_gating enable_disp_power_gating;
/**
* Definition of a DMUB_CMD__VBIOS_DPPHY_INIT command.
*/
struct dmub_rb_cmd_dpphy_init dpphy_init; struct dmub_rb_cmd_dpphy_init dpphy_init;
/**
* Definition of a DMUB_CMD__VBIOS_DIG1_TRANSMITTER_CONTROL command.
*/
struct dmub_rb_cmd_dig1_transmitter_control dig1_transmitter_control; struct dmub_rb_cmd_dig1_transmitter_control dig1_transmitter_control;
/** /**
* Definition of a DMUB_CMD__PSR_SET_VERSION command. * Definition of a DMUB_CMD__PSR_SET_VERSION command.
...@@ -1617,7 +1898,13 @@ union dmub_rb_cmd { ...@@ -1617,7 +1898,13 @@ union dmub_rb_cmd {
* Definition of a DMUB_CMD__PSR_FORCE_STATIC command. * Definition of a DMUB_CMD__PSR_FORCE_STATIC command.
*/ */
struct dmub_rb_cmd_psr_force_static psr_force_static; struct dmub_rb_cmd_psr_force_static psr_force_static;
/**
* Definition of a DMUB_CMD__PLAT_54186_WA command.
*/
struct dmub_rb_cmd_PLAT_54186_wa PLAT_54186_wa; struct dmub_rb_cmd_PLAT_54186_wa PLAT_54186_wa;
/**
* Definition of a DMUB_CMD__MALL command.
*/
struct dmub_rb_cmd_mall mall; struct dmub_rb_cmd_mall mall;
/** /**
* Definition of a DMUB_CMD__ABM_SET_PIPE command. * Definition of a DMUB_CMD__ABM_SET_PIPE command.
...@@ -1654,20 +1941,40 @@ union dmub_rb_cmd { ...@@ -1654,20 +1941,40 @@ union dmub_rb_cmd {
*/ */
struct dmub_rb_cmd_dp_aux_access dp_aux_access; struct dmub_rb_cmd_dp_aux_access dp_aux_access;
/**
* Definition of a DMUB_CMD__OUTBOX1_ENABLE command.
*/
struct dmub_rb_cmd_outbox1_enable outbox1_enable; struct dmub_rb_cmd_outbox1_enable outbox1_enable;
/** /**
* Definition of a DMUB_CMD__qyert command. * Definition of a DMUB_CMD__QUERY_FEATURE_CAPS command.
*/ */
struct dmub_rb_cmd_query_feature_caps query_feature_caps; struct dmub_rb_cmd_query_feature_caps query_feature_caps;
struct dmub_rb_cmd_drr_update drr_update;
#ifndef TRIM_FAMS
struct dmub_rb_cmd_fw_assisted_mclk_switch fw_assisted_mclk_switch;
#endif
/** /**
* Definition of a DMUB_CMD__VBIOS_LVTMA_CONTROL command. * Definition of a DMUB_CMD__VBIOS_LVTMA_CONTROL command.
*/ */
struct dmub_rb_cmd_lvtma_control lvtma_control; struct dmub_rb_cmd_lvtma_control lvtma_control;
}; };
/**
* union dmub_rb_out_cmd - Outbox command
*/
union dmub_rb_out_cmd { union dmub_rb_out_cmd {
/**
* Parameters common to every command.
*/
struct dmub_rb_cmd_common cmd_common; struct dmub_rb_cmd_common cmd_common;
/**
* AUX reply command.
*/
struct dmub_rb_cmd_dp_aux_reply dp_aux_reply; struct dmub_rb_cmd_dp_aux_reply dp_aux_reply;
/**
* HPD notify command.
*/
struct dmub_rb_cmd_dp_hpd_notify dp_hpd_notify; struct dmub_rb_cmd_dp_hpd_notify dp_hpd_notify;
}; };
#pragma pack(pop) #pragma pack(pop)
...@@ -1683,31 +1990,49 @@ union dmub_rb_out_cmd { ...@@ -1683,31 +1990,49 @@ union dmub_rb_out_cmd {
extern "C" { extern "C" {
#endif #endif
/**
* struct dmub_rb_init_params - Initialization params for DMUB ringbuffer
*/
struct dmub_rb_init_params { struct dmub_rb_init_params {
void *ctx; void *ctx; /**< Caller provided context pointer */
void *base_address; void *base_address; /**< CPU base address for ring's data */
uint32_t capacity; uint32_t capacity; /**< Ringbuffer capacity in bytes */
uint32_t read_ptr; uint32_t read_ptr; /**< Initial read pointer for consumer in bytes */
uint32_t write_ptr; uint32_t write_ptr; /**< Initial write pointer for producer in bytes */
}; };
/**
* struct dmub_rb - Inbox or outbox DMUB ringbuffer
*/
struct dmub_rb { struct dmub_rb {
void *base_address; void *base_address; /**< CPU address for the ring's data */
uint32_t data_count; uint32_t rptr; /**< Read pointer for consumer in bytes */
uint32_t rptr; uint32_t wrpt; /**< Write pointer for producer in bytes */
uint32_t wrpt; uint32_t capacity; /**< Ringbuffer capacity in bytes */
uint32_t capacity;
void *ctx; void *ctx; /**< Caller provided context pointer */
void *dmub; void *dmub; /**< Pointer to the DMUB interface */
}; };
/**
* @brief Checks if the ringbuffer is empty.
*
* @param rb DMUB Ringbuffer
* @return true if empty
* @return false otherwise
*/
static inline bool dmub_rb_empty(struct dmub_rb *rb) static inline bool dmub_rb_empty(struct dmub_rb *rb)
{ {
return (rb->wrpt == rb->rptr); return (rb->wrpt == rb->rptr);
} }
/**
* @brief Checks if the ringbuffer is full
*
* @param rb DMUB Ringbuffer
* @return true if full
* @return false otherwise
*/
static inline bool dmub_rb_full(struct dmub_rb *rb) static inline bool dmub_rb_full(struct dmub_rb *rb)
{ {
uint32_t data_count; uint32_t data_count;
...@@ -1720,6 +2045,14 @@ static inline bool dmub_rb_full(struct dmub_rb *rb) ...@@ -1720,6 +2045,14 @@ static inline bool dmub_rb_full(struct dmub_rb *rb)
return (data_count == (rb->capacity - DMUB_RB_CMD_SIZE)); return (data_count == (rb->capacity - DMUB_RB_CMD_SIZE));
} }
/**
* @brief Pushes a command into the ringbuffer
*
* @param rb DMUB ringbuffer
* @param cmd The command to push
* @return true if the ringbuffer was not full
* @return false otherwise
*/
static inline bool dmub_rb_push_front(struct dmub_rb *rb, static inline bool dmub_rb_push_front(struct dmub_rb *rb,
const union dmub_rb_cmd *cmd) const union dmub_rb_cmd *cmd)
{ {
...@@ -1742,6 +2075,14 @@ static inline bool dmub_rb_push_front(struct dmub_rb *rb, ...@@ -1742,6 +2075,14 @@ static inline bool dmub_rb_push_front(struct dmub_rb *rb,
return true; return true;
} }
/**
* @brief Pushes a command into the DMUB outbox ringbuffer
*
* @param rb DMUB outbox ringbuffer
* @param cmd Outbox command
* @return true if not full
* @return false otherwise
*/
static inline bool dmub_rb_out_push_front(struct dmub_rb *rb, static inline bool dmub_rb_out_push_front(struct dmub_rb *rb,
const union dmub_rb_out_cmd *cmd) const union dmub_rb_out_cmd *cmd)
{ {
...@@ -1761,6 +2102,14 @@ static inline bool dmub_rb_out_push_front(struct dmub_rb *rb, ...@@ -1761,6 +2102,14 @@ static inline bool dmub_rb_out_push_front(struct dmub_rb *rb,
return true; return true;
} }
/**
* @brief Returns the next unprocessed command in the ringbuffer.
*
* @param rb DMUB ringbuffer
* @param cmd The command to return
* @return true if not empty
* @return false otherwise
*/
static inline bool dmub_rb_front(struct dmub_rb *rb, static inline bool dmub_rb_front(struct dmub_rb *rb,
union dmub_rb_cmd **cmd) union dmub_rb_cmd **cmd)
{ {
...@@ -1774,6 +2123,14 @@ static inline bool dmub_rb_front(struct dmub_rb *rb, ...@@ -1774,6 +2123,14 @@ static inline bool dmub_rb_front(struct dmub_rb *rb,
return true; return true;
} }
/**
* @brief Returns the next unprocessed command in the outbox.
*
* @param rb DMUB outbox ringbuffer
* @param cmd The outbox command to return
* @return true if not empty
* @return false otherwise
*/
static inline bool dmub_rb_out_front(struct dmub_rb *rb, static inline bool dmub_rb_out_front(struct dmub_rb *rb,
union dmub_rb_out_cmd *cmd) union dmub_rb_out_cmd *cmd)
{ {
...@@ -1791,6 +2148,13 @@ static inline bool dmub_rb_out_front(struct dmub_rb *rb, ...@@ -1791,6 +2148,13 @@ static inline bool dmub_rb_out_front(struct dmub_rb *rb,
return true; return true;
} }
/**
* @brief Removes the front entry in the ringbuffer.
*
* @param rb DMUB ringbuffer
* @return true if the command was removed
* @return false if there were no commands
*/
static inline bool dmub_rb_pop_front(struct dmub_rb *rb) static inline bool dmub_rb_pop_front(struct dmub_rb *rb)
{ {
if (dmub_rb_empty(rb)) if (dmub_rb_empty(rb))
...@@ -1804,6 +2168,14 @@ static inline bool dmub_rb_pop_front(struct dmub_rb *rb) ...@@ -1804,6 +2168,14 @@ static inline bool dmub_rb_pop_front(struct dmub_rb *rb)
return true; return true;
} }
/**
* @brief Flushes commands in the ringbuffer to framebuffer memory.
*
* Avoids a race condition where DMCUB accesses memory while
* there are still writes in flight to framebuffer.
*
* @param rb DMUB ringbuffer
*/
static inline void dmub_rb_flush_pending(const struct dmub_rb *rb) static inline void dmub_rb_flush_pending(const struct dmub_rb *rb)
{ {
uint32_t rptr = rb->rptr; uint32_t rptr = rb->rptr;
...@@ -1822,6 +2194,12 @@ static inline void dmub_rb_flush_pending(const struct dmub_rb *rb) ...@@ -1822,6 +2194,12 @@ static inline void dmub_rb_flush_pending(const struct dmub_rb *rb)
} }
} }
/**
* @brief Initializes a DMCUB ringbuffer
*
* @param rb DMUB ringbuffer
* @param init_params initial configuration for the ringbuffer
*/
static inline void dmub_rb_init(struct dmub_rb *rb, static inline void dmub_rb_init(struct dmub_rb *rb,
struct dmub_rb_init_params *init_params) struct dmub_rb_init_params *init_params)
{ {
...@@ -1831,6 +2209,12 @@ static inline void dmub_rb_init(struct dmub_rb *rb, ...@@ -1831,6 +2209,12 @@ static inline void dmub_rb_init(struct dmub_rb *rb,
rb->wrpt = init_params->write_ptr; rb->wrpt = init_params->write_ptr;
} }
/**
* @brief Copies output data from in/out commands into the given command.
*
* @param rb DMUB ringbuffer
* @param cmd Command to copy data into
*/
static inline void dmub_rb_get_return_data(struct dmub_rb *rb, static inline void dmub_rb_get_return_data(struct dmub_rb *rb,
union dmub_rb_cmd *cmd) union dmub_rb_cmd *cmd)
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment