Commit 59687820 authored by Takashi Iwai's avatar Takashi Iwai Committed by Luis Henriques

ALSA: hda - Limit 40bit DMA for AMD HDMI controllers

commit 413cbf46 upstream.

AMD/ATI HDMI controller chip models, we already have a filter to lower
to 32bit DMA, but the rest are supposed to be working with 64bit
although the hardware doesn't really work with 63bit but only with 40
or 48bit DMA.  In this patch, we take 40bit DMA for safety for the
AMD/ATI controllers as the graphics drivers does.
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
[ luis: backported to 3.16:
  - replaced AZX_GCAP_64OK by ICH6_GCAP_64OK ]
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent d4ffe316
...@@ -1273,6 +1273,7 @@ static int azx_first_init(struct azx *chip) ...@@ -1273,6 +1273,7 @@ static int azx_first_init(struct azx *chip)
struct snd_card *card = chip->card; struct snd_card *card = chip->card;
int err; int err;
unsigned short gcap; unsigned short gcap;
unsigned int dma_bits = 64;
#if BITS_PER_LONG != 64 #if BITS_PER_LONG != 64
/* Fix up base address on ULI M5461 */ /* Fix up base address on ULI M5461 */
...@@ -1309,9 +1310,14 @@ static int azx_first_init(struct azx *chip) ...@@ -1309,9 +1310,14 @@ static int azx_first_init(struct azx *chip)
gcap = azx_readw(chip, GCAP); gcap = azx_readw(chip, GCAP);
dev_dbg(card->dev, "chipset global capabilities = 0x%x\n", gcap); dev_dbg(card->dev, "chipset global capabilities = 0x%x\n", gcap);
/* AMD devices support 40 or 48bit DMA, take the safe one */
if (chip->pci->vendor == PCI_VENDOR_ID_AMD)
dma_bits = 40;
/* disable SB600 64bit support for safety */ /* disable SB600 64bit support for safety */
if (chip->pci->vendor == PCI_VENDOR_ID_ATI) { if (chip->pci->vendor == PCI_VENDOR_ID_ATI) {
struct pci_dev *p_smbus; struct pci_dev *p_smbus;
dma_bits = 40;
p_smbus = pci_get_device(PCI_VENDOR_ID_ATI, p_smbus = pci_get_device(PCI_VENDOR_ID_ATI,
PCI_DEVICE_ID_ATI_SBX00_SMBUS, PCI_DEVICE_ID_ATI_SBX00_SMBUS,
NULL); NULL);
...@@ -1341,9 +1347,11 @@ static int azx_first_init(struct azx *chip) ...@@ -1341,9 +1347,11 @@ static int azx_first_init(struct azx *chip)
} }
/* allow 64bit DMA address if supported by H/W */ /* allow 64bit DMA address if supported by H/W */
if ((gcap & ICH6_GCAP_64OK) && !pci_set_dma_mask(pci, DMA_BIT_MASK(64))) if (!(gcap & ICH6_GCAP_64OK))
pci_set_consistent_dma_mask(pci, DMA_BIT_MASK(64)); dma_bits = 32;
else { if (!pci_set_dma_mask(pci, DMA_BIT_MASK(dma_bits))) {
pci_set_consistent_dma_mask(pci, DMA_BIT_MASK(dma_bits));
} else {
pci_set_dma_mask(pci, DMA_BIT_MASK(32)); pci_set_dma_mask(pci, DMA_BIT_MASK(32));
pci_set_consistent_dma_mask(pci, DMA_BIT_MASK(32)); pci_set_consistent_dma_mask(pci, DMA_BIT_MASK(32));
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment