Commit 59c0d7b1 authored by Christian Engelmayer's avatar Christian Engelmayer Committed by Mauro Carvalho Chehab

[media] mn88472: Fix possible leak in mn88472_init()

Commit 307e95c9 ("[media] mn88472: implement firmware parity check")
introduced the usage of exit paths that do not free the already allocated
firmware data in case the parity handling fails. Go through the correct
exit paths. Detected by Coverity CID 1295989.
Signed-off-by: default avatarChristian Engelmayer <cengelma@gmx.at>
Acked-by: default avatarBenjamin Larsson <benjamin@southpole.se>
Signed-off-by: default avatarAntti Palosaari <crope@iki.fi>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 699dcffc
...@@ -344,12 +344,12 @@ static int mn88472_init(struct dvb_frontend *fe) ...@@ -344,12 +344,12 @@ static int mn88472_init(struct dvb_frontend *fe)
if (ret) { if (ret) {
dev_err(&client->dev, dev_err(&client->dev,
"parity reg read failed=%d\n", ret); "parity reg read failed=%d\n", ret);
goto err; goto firmware_release;
} }
if (tmp & 0x10) { if (tmp & 0x10) {
dev_err(&client->dev, dev_err(&client->dev,
"firmware parity check failed=0x%x\n", tmp); "firmware parity check failed=0x%x\n", tmp);
goto err; goto firmware_release;
} }
dev_err(&client->dev, "firmware parity check succeeded=0x%x\n", tmp); dev_err(&client->dev, "firmware parity check succeeded=0x%x\n", tmp);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment