Commit 5a0e2cd5 authored by Grant Grundler's avatar Grant Grundler Committed by Jeff Garzik

[netdrvr] typhoon: typhoon_resume - remove call to start_queue

While trying to fix http://bugzilla.kernel.org/show_bug.cgi?id=8952
I looked at a few other drivers to figure out what drivers _should_
be doing for suspend/resume. I noticed typhoon driver is likely doing
more than it needs to.  Patch below is untested since I don't have the HW.

Suspend/resume code across NIC drivers is fairly inconsistent.
And I couldn't find any documentation on what the canonical sequence
NICs need to do for suspend or resume.  Is there any?

Barring contrary advice, I'm going model the tulip suspend/resume
fixes after tg3.c since a number of "modern" (< 5 years old) laptops
have that and I'm silly enough to assume it works.
Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
parent 11121e30
...@@ -2183,7 +2183,6 @@ typhoon_resume(struct pci_dev *pdev) ...@@ -2183,7 +2183,6 @@ typhoon_resume(struct pci_dev *pdev)
} }
netif_device_attach(dev); netif_device_attach(dev);
netif_start_queue(dev);
return 0; return 0;
reset: reset:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment