Commit 5b2766ff authored by Tyrel Datwyler's avatar Tyrel Datwyler Committed by Luis Henriques

powerpc/pseries: Little endian fixes for post mobility device tree update

commit f6ff0414 upstream.

We currently use the device tree update code in the kernel after resuming
from a suspend operation to re-sync the kernels view of the device tree with
that of the hypervisor. The code as it stands is not endian safe as it relies
on parsing buffers returned by RTAS calls that thusly contains data in big
endian format.

This patch annotates variables and structure members with __be types as well
as performing necessary byte swaps to cpu endian for data that needs to be
parsed.
Signed-off-by: default avatarTyrel Datwyler <tyreld@linux.vnet.ibm.com>
Cc: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Cc: Cyril Bur <cyrilbur@gmail.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent 2f55b0b6
...@@ -24,10 +24,10 @@ ...@@ -24,10 +24,10 @@
static struct kobject *mobility_kobj; static struct kobject *mobility_kobj;
struct update_props_workarea { struct update_props_workarea {
u32 phandle; __be32 phandle;
u32 state; __be32 state;
u64 reserved; __be64 reserved;
u32 nprops; __be32 nprops;
} __packed; } __packed;
#define NODE_ACTION_MASK 0xff000000 #define NODE_ACTION_MASK 0xff000000
...@@ -53,11 +53,11 @@ static int mobility_rtas_call(int token, char *buf, s32 scope) ...@@ -53,11 +53,11 @@ static int mobility_rtas_call(int token, char *buf, s32 scope)
return rc; return rc;
} }
static int delete_dt_node(u32 phandle) static int delete_dt_node(__be32 phandle)
{ {
struct device_node *dn; struct device_node *dn;
dn = of_find_node_by_phandle(phandle); dn = of_find_node_by_phandle(be32_to_cpu(phandle));
if (!dn) if (!dn)
return -ENOENT; return -ENOENT;
...@@ -126,7 +126,7 @@ static int update_dt_property(struct device_node *dn, struct property **prop, ...@@ -126,7 +126,7 @@ static int update_dt_property(struct device_node *dn, struct property **prop,
return 0; return 0;
} }
static int update_dt_node(u32 phandle, s32 scope) static int update_dt_node(__be32 phandle, s32 scope)
{ {
struct update_props_workarea *upwa; struct update_props_workarea *upwa;
struct device_node *dn; struct device_node *dn;
...@@ -135,6 +135,7 @@ static int update_dt_node(u32 phandle, s32 scope) ...@@ -135,6 +135,7 @@ static int update_dt_node(u32 phandle, s32 scope)
char *prop_data; char *prop_data;
char *rtas_buf; char *rtas_buf;
int update_properties_token; int update_properties_token;
u32 nprops;
u32 vd; u32 vd;
update_properties_token = rtas_token("ibm,update-properties"); update_properties_token = rtas_token("ibm,update-properties");
...@@ -145,7 +146,7 @@ static int update_dt_node(u32 phandle, s32 scope) ...@@ -145,7 +146,7 @@ static int update_dt_node(u32 phandle, s32 scope)
if (!rtas_buf) if (!rtas_buf)
return -ENOMEM; return -ENOMEM;
dn = of_find_node_by_phandle(phandle); dn = of_find_node_by_phandle(be32_to_cpu(phandle));
if (!dn) { if (!dn) {
kfree(rtas_buf); kfree(rtas_buf);
return -ENOENT; return -ENOENT;
...@@ -161,6 +162,7 @@ static int update_dt_node(u32 phandle, s32 scope) ...@@ -161,6 +162,7 @@ static int update_dt_node(u32 phandle, s32 scope)
break; break;
prop_data = rtas_buf + sizeof(*upwa); prop_data = rtas_buf + sizeof(*upwa);
nprops = be32_to_cpu(upwa->nprops);
/* On the first call to ibm,update-properties for a node the /* On the first call to ibm,update-properties for a node the
* the first property value descriptor contains an empty * the first property value descriptor contains an empty
...@@ -169,17 +171,17 @@ static int update_dt_node(u32 phandle, s32 scope) ...@@ -169,17 +171,17 @@ static int update_dt_node(u32 phandle, s32 scope)
*/ */
if (*prop_data == 0) { if (*prop_data == 0) {
prop_data++; prop_data++;
vd = *(u32 *)prop_data; vd = be32_to_cpu(*(__be32 *)prop_data);
prop_data += vd + sizeof(vd); prop_data += vd + sizeof(vd);
upwa->nprops--; nprops--;
} }
for (i = 0; i < upwa->nprops; i++) { for (i = 0; i < nprops; i++) {
char *prop_name; char *prop_name;
prop_name = prop_data; prop_name = prop_data;
prop_data += strlen(prop_name) + 1; prop_data += strlen(prop_name) + 1;
vd = *(u32 *)prop_data; vd = be32_to_cpu(*(__be32 *)prop_data);
prop_data += sizeof(vd); prop_data += sizeof(vd);
switch (vd) { switch (vd) {
...@@ -211,13 +213,13 @@ static int update_dt_node(u32 phandle, s32 scope) ...@@ -211,13 +213,13 @@ static int update_dt_node(u32 phandle, s32 scope)
return 0; return 0;
} }
static int add_dt_node(u32 parent_phandle, u32 drc_index) static int add_dt_node(__be32 parent_phandle, __be32 drc_index)
{ {
struct device_node *dn; struct device_node *dn;
struct device_node *parent_dn; struct device_node *parent_dn;
int rc; int rc;
parent_dn = of_find_node_by_phandle(parent_phandle); parent_dn = of_find_node_by_phandle(be32_to_cpu(parent_phandle));
if (!parent_dn) if (!parent_dn)
return -ENOENT; return -ENOENT;
...@@ -236,7 +238,7 @@ static int add_dt_node(u32 parent_phandle, u32 drc_index) ...@@ -236,7 +238,7 @@ static int add_dt_node(u32 parent_phandle, u32 drc_index)
int pseries_devicetree_update(s32 scope) int pseries_devicetree_update(s32 scope)
{ {
char *rtas_buf; char *rtas_buf;
u32 *data; __be32 *data;
int update_nodes_token; int update_nodes_token;
int rc; int rc;
...@@ -253,17 +255,17 @@ int pseries_devicetree_update(s32 scope) ...@@ -253,17 +255,17 @@ int pseries_devicetree_update(s32 scope)
if (rc && rc != 1) if (rc && rc != 1)
break; break;
data = (u32 *)rtas_buf + 4; data = (__be32 *)rtas_buf + 4;
while (*data & NODE_ACTION_MASK) { while (be32_to_cpu(*data) & NODE_ACTION_MASK) {
int i; int i;
u32 action = *data & NODE_ACTION_MASK; u32 action = be32_to_cpu(*data) & NODE_ACTION_MASK;
int node_count = *data & NODE_COUNT_MASK; u32 node_count = be32_to_cpu(*data) & NODE_COUNT_MASK;
data++; data++;
for (i = 0; i < node_count; i++) { for (i = 0; i < node_count; i++) {
u32 phandle = *data++; __be32 phandle = *data++;
u32 drc_index; __be32 drc_index;
switch (action) { switch (action) {
case DELETE_DT_NODE: case DELETE_DT_NODE:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment