Commit 5bbb2ae3 authored by Paul Bolle's avatar Paul Bolle Committed by Greg Kroah-Hartman

raw: test against runtime value of max_raw_minors

bind_get() checks the device number it is called with. It uses
MAX_RAW_MINORS for the upper bound. But MAX_RAW_MINORS is set at compile
time while the actual number of raw devices can be set at runtime. This
means the test can either be too strict or too lenient. And if the test
ends up being too lenient bind_get() might try to access memory beyond
what was allocated for "raw_devices".

So check against the runtime value (max_raw_minors) in this function.
Signed-off-by: default avatarPaul Bolle <pebolle@tiscali.nl>
Acked-by: default avatarJan Kara <jack@suse.cz>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 269f9794
...@@ -190,7 +190,7 @@ static int bind_get(int number, dev_t *dev) ...@@ -190,7 +190,7 @@ static int bind_get(int number, dev_t *dev)
struct raw_device_data *rawdev; struct raw_device_data *rawdev;
struct block_device *bdev; struct block_device *bdev;
if (number <= 0 || number >= MAX_RAW_MINORS) if (number <= 0 || number >= max_raw_minors)
return -EINVAL; return -EINVAL;
rawdev = &raw_devices[number]; rawdev = &raw_devices[number];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment