Commit 5c25f65f authored by Julien Gomes's avatar Julien Gomes Committed by David S. Miller

tun: allow positive return values on dev_get_valid_name() call

If the name argument of dev_get_valid_name() contains "%d", it will try
to assign it a unit number in __dev__alloc_name() and return either the
unit number (>= 0) or an error code (< 0).
Considering positive values as error values prevent tun device creations
relying this mechanism, therefor we should only consider negative values
as errors here.
Signed-off-by: default avatarJulien Gomes <julien@arista.com>
Acked-by: default avatarCong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d309ae5c
...@@ -2028,7 +2028,7 @@ static int tun_set_iff(struct net *net, struct file *file, struct ifreq *ifr) ...@@ -2028,7 +2028,7 @@ static int tun_set_iff(struct net *net, struct file *file, struct ifreq *ifr)
if (!dev) if (!dev)
return -ENOMEM; return -ENOMEM;
err = dev_get_valid_name(net, dev, name); err = dev_get_valid_name(net, dev, name);
if (err) if (err < 0)
goto err_free_dev; goto err_free_dev;
dev_net_set(dev, net); dev_net_set(dev, net);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment