Commit 5da4e689 authored by Al Viro's avatar Al Viro

devtmpfs: get rid of bogus mkdir in create_path()

We do _NOT_ want to mkdir the path itself - we are preparing to
mknod it, after all.  Normally it'll fail with -ENOENT and
just do nothing, but if somebody has created the parent in
the meanwhile, we'll get buggered...
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 69753a0f
...@@ -164,34 +164,28 @@ static int dev_mkdir(const char *name, mode_t mode) ...@@ -164,34 +164,28 @@ static int dev_mkdir(const char *name, mode_t mode)
static int create_path(const char *nodepath) static int create_path(const char *nodepath)
{ {
char *path;
char *s;
int err; int err;
err = dev_mkdir(nodepath, 0755); /* parent directories do not exist, create them */
if (err == -ENOENT) { path = kstrdup(nodepath, GFP_KERNEL);
char *path; if (!path)
char *s; return -ENOMEM;
/* parent directories do not exist, create them */ s = path;
path = kstrdup(nodepath, GFP_KERNEL); for (;;) {
if (!path) { s = strchr(s, '/');
err = -ENOMEM; if (!s)
goto out; break;
} s[0] = '\0';
s = path; err = dev_mkdir(path, 0755);
for (;;) { if (err && err != -EEXIST)
s = strchr(s, '/'); break;
if (!s) s[0] = '/';
break; s++;
s[0] = '\0';
err = dev_mkdir(path, 0755);
if (err && err != -EEXIST)
break;
s[0] = '/';
s++;
}
kfree(path);
} }
out: kfree(path);
return err; return err;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment