Commit 5ddd1132 authored by Daeseok Youn's avatar Daeseok Youn Committed by Greg Kroah-Hartman

staging: cxt1e1: remove redundant memset() call

The banner array doens't need to set to 0.
sprintf() adds a terminating '\0'.

And the sn array can be declared and initialized to zero.
So remove redundant memset() with zero.

Remove unnecessary cast for memcpy().
Signed-off-by: default avatarDaeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 14eec444
...@@ -51,22 +51,16 @@ show_two(hdw_info_t *hi, int brdno) ...@@ -51,22 +51,16 @@ show_two(hdw_info_t *hi, int brdno)
struct pci_dev *pdev; struct pci_dev *pdev;
char *bid; char *bid;
char banner[80]; char banner[80];
char sn[6]; char sn[6] = {0,};
/* clear print buffer */
memset(banner, 0, 80);
ci = (ci_t *)(netdev_priv(hi->ndev)); ci = (ci_t *)(netdev_priv(hi->ndev));
bid = sbeid_get_bdname(ci); bid = sbeid_get_bdname(ci);
switch (hi->promfmt) { switch (hi->promfmt) {
case PROM_FORMAT_TYPE1: case PROM_FORMAT_TYPE1:
memcpy(sn, (FLD_TYPE1 *)(hi->mfg_info.pft1.Serial), 6); memcpy(sn, hi->mfg_info.pft1.Serial, 6);
break; break;
case PROM_FORMAT_TYPE2: case PROM_FORMAT_TYPE2:
memcpy(sn, (FLD_TYPE2 *)(hi->mfg_info.pft2.Serial), 6); memcpy(sn, hi->mfg_info.pft2.Serial, 6);
break;
default:
memset(sn, 0, 6);
break; break;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment