Commit 5e351cae authored by Guenter Roeck's avatar Guenter Roeck Committed by Greg Kroah-Hartman

hwmon: (ds620) Fix overflows seen when writing temperature limits

commit e36ce99e upstream.

Module test reports:

temp1_max: Suspected overflow: [160000 vs. 0]
temp1_min: Suspected overflow: [160000 vs. 0]

This is seen because the values passed when writing temperature limits
are unbound.
Reviewed-by: default avatarJean Delvare <jdelvare@suse.de>
Fixes: 60994698 ("hwmon: Support for Dallas Semiconductor DS620")
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fbab1832
...@@ -166,7 +166,7 @@ static ssize_t set_temp(struct device *dev, struct device_attribute *da, ...@@ -166,7 +166,7 @@ static ssize_t set_temp(struct device *dev, struct device_attribute *da,
if (res) if (res)
return res; return res;
val = (val * 10 / 625) * 8; val = (clamp_val(val, -128000, 128000) * 10 / 625) * 8;
mutex_lock(&data->update_lock); mutex_lock(&data->update_lock);
data->temp[attr->index] = val; data->temp[attr->index] = val;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment