Commit 5e60d790 authored by Arun Siluvery's avatar Arun Siluvery Committed by Daniel Vetter

drm/i915: Bail out early if WA batch is not available for given Gen

To initialize WA batch, at the moment we first allocate batch and then check
whether we have any WA to be initialized for the given Gen; if we don't have
any WA then we WARN the user, destroy the batch and return but this is causing
another WARN in cleanup code complaining about sleeping in atomic context.
Till we understand this better and to keep things simpler, bail out early
if we don't have WA.

Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: default avatarArun Siluvery <arun.siluvery@linux.intel.com>
Reviewed-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 4d78c8dc
...@@ -1260,6 +1260,12 @@ static int intel_init_workaround_bb(struct intel_engine_cs *ring) ...@@ -1260,6 +1260,12 @@ static int intel_init_workaround_bb(struct intel_engine_cs *ring)
WARN_ON(ring->id != RCS); WARN_ON(ring->id != RCS);
/* update this when WA for higher Gen are added */
if (WARN(INTEL_INFO(ring->dev)->gen > 8,
"WA batch buffer is not initialized for Gen%d\n",
INTEL_INFO(ring->dev)->gen))
return 0;
/* some WA perform writes to scratch page, ensure it is valid */ /* some WA perform writes to scratch page, ensure it is valid */
if (ring->scratch.obj == NULL) { if (ring->scratch.obj == NULL) {
DRM_ERROR("scratch page not allocated for %s\n", ring->name); DRM_ERROR("scratch page not allocated for %s\n", ring->name);
...@@ -1290,11 +1296,6 @@ static int intel_init_workaround_bb(struct intel_engine_cs *ring) ...@@ -1290,11 +1296,6 @@ static int intel_init_workaround_bb(struct intel_engine_cs *ring)
&offset); &offset);
if (ret) if (ret)
goto out; goto out;
} else {
WARN(INTEL_INFO(ring->dev)->gen >= 8,
"WA batch buffer is not initialized for Gen%d\n",
INTEL_INFO(ring->dev)->gen);
lrc_destroy_wa_ctx_obj(ring);
} }
out: out:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment